From 7130e4bde71016e4e27e775830ddf1c73db9d1fa Mon Sep 17 00:00:00 2001 From: Ewan Chou Date: Tue, 22 Dec 2015 21:38:10 +0800 Subject: [PATCH] tide-server: avoid panic when failed in SetupSuite. Have taken a look at `go check` source code, `TearDownSuite` will always be called even if it failed in `SetUpSuite`. --- tidb-server/server/tidb_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tidb-server/server/tidb_test.go b/tidb-server/server/tidb_test.go index e60ec6d025..adb0a2f371 100644 --- a/tidb-server/server/tidb_test.go +++ b/tidb-server/server/tidb_test.go @@ -43,7 +43,9 @@ func (ts *TidbTestSuite) SetUpSuite(c *C) { } func (ts *TidbTestSuite) TearDownSuite(c *C) { - ts.server.Close() + if ts.server != nil { + ts.server.Close() + } } func (ts *TidbTestSuite) TestRegression(c *C) {