From 89ba8fd5658f18ee8b84df87fe0675e2fda6445f Mon Sep 17 00:00:00 2001 From: David <8039876+AmoebaProtozoa@users.noreply.github.com> Date: Fri, 25 Aug 2023 21:57:35 +0800 Subject: [PATCH] *: fix ineffective failpoint enable in TestMPPExecution (#46429) --- executor/test/tiflashtest/tiflash_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/executor/test/tiflashtest/tiflash_test.go b/executor/test/tiflashtest/tiflash_test.go index 1a4891b83f..e15005b95c 100644 --- a/executor/test/tiflashtest/tiflash_test.go +++ b/executor/test/tiflashtest/tiflash_test.go @@ -272,10 +272,10 @@ func TestMppExecution(t *testing.T) { require.Equal(t, int64(1), taskID) tk.MustExec("commit") - failpoint.Enable("github.com/pingcap/tidb/executor/checkTotalMPPTasks", `return(3)`) + require.NoError(t, failpoint.Enable("github.com/pingcap/tidb/executor/internal/mpp/checkTotalMPPTasks", `return(3)`)) // all the data is related to one store, so there are three tasks. tk.MustQuery("select avg(t.a) from t join t t1 on t.a = t1.a").Check(testkit.Rows("2.0000")) - failpoint.Disable("github.com/pingcap/tidb/executor/internal/mpp/checkTotalMPPTasks") + require.NoError(t, failpoint.Disable("github.com/pingcap/tidb/executor/internal/mpp/checkTotalMPPTasks")) tk.MustExec("drop table if exists t") tk.MustExec("create table t (c1 decimal(8, 5) not null, c2 decimal(9, 5), c3 decimal(9, 4) , c4 decimal(8, 4) not null)")