From bc00938e5be5f95ce3e3c0bf879f3dbec159cac4 Mon Sep 17 00:00:00 2001 From: CbcWestwolf <1004626265@qq.com> Date: Tue, 13 Sep 2022 19:52:57 +0800 Subject: [PATCH] ddl: fix exposion of magic number (#37786) close pingcap/tidb#37686 --- ddl/ddl_api.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ddl/ddl_api.go b/ddl/ddl_api.go index 2554dcfa7c..812a5b3794 100644 --- a/ddl/ddl_api.go +++ b/ddl/ddl_api.go @@ -4335,8 +4335,10 @@ func processColumnOptions(ctx sessionctx.Context, col *table.Column, options []* col.DelFlag(mysql.NotNullFlag) case ast.ColumnOptionAutoIncrement: col.AddFlag(mysql.AutoIncrementFlag) - case ast.ColumnOptionPrimaryKey, ast.ColumnOptionUniqKey: - return dbterror.ErrUnsupportedModifyColumn.GenWithStack("can't change column constraint - %v", opt.Tp) + case ast.ColumnOptionPrimaryKey: + return errors.Trace(dbterror.ErrUnsupportedModifyColumn.GenWithStack("can't change column constraint (PRIMARY KEY)")) + case ast.ColumnOptionUniqKey: + return errors.Trace(dbterror.ErrUnsupportedModifyColumn.GenWithStack("can't change column constraint (UNIQUE KEY)")) case ast.ColumnOptionOnUpdate: // TODO: Support other time functions. if col.GetType() == mysql.TypeTimestamp || col.GetType() == mysql.TypeDatetime {