From be6163c823285eb7bd048c8d0377c7b05dfd464e Mon Sep 17 00:00:00 2001 From: Brooks Liu Date: Tue, 8 Oct 2019 15:49:01 +0800 Subject: [PATCH] expression: implement vectorized evaluation for `builtinRealIsFalseSig` (#12527) --- expression/builtin_op_vec.go | 24 ++++++++++++++++++++++-- expression/builtin_op_vec_test.go | 1 + 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/expression/builtin_op_vec.go b/expression/builtin_op_vec.go index bbf3bd1788..06de2b0bfb 100644 --- a/expression/builtin_op_vec.go +++ b/expression/builtin_op_vec.go @@ -325,11 +325,31 @@ func (b *builtinBitAndSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) } func (b *builtinRealIsFalseSig) vectorized() bool { - return false + return true } func (b *builtinRealIsFalseSig) vecEvalInt(input *chunk.Chunk, result *chunk.Column) error { - return errors.Errorf("not implemented") + numRows := input.NumRows() + buf, err := b.bufAllocator.get(types.ETReal, numRows) + if err != nil { + return err + } + defer b.bufAllocator.put(buf) + if err := b.args[0].VecEvalReal(b.ctx, input, buf); err != nil { + return err + } + + result.ResizeInt64(numRows, false) + i64s := result.Int64s() + bufI64s := buf.Int64s() + for i := 0; i < numRows; i++ { + if buf.IsNull(i) || bufI64s[i] != 0 { + i64s[i] = 0 + } else { + i64s[i] = 1 + } + } + return nil } func (b *builtinUnaryMinusIntSig) vectorized() bool { diff --git a/expression/builtin_op_vec_test.go b/expression/builtin_op_vec_test.go index d5578374de..c68869119c 100644 --- a/expression/builtin_op_vec_test.go +++ b/expression/builtin_op_vec_test.go @@ -27,6 +27,7 @@ var vecBuiltinOpCases = map[string][]vecExprBenchCase{ {retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETDecimal}, geners: []dataGenerator{&defaultGener{0.2, types.ETDecimal}}}, }, ast.IsFalsity: { + {retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETReal}}, {retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETDecimal}}, }, ast.LogicOr: {