From cf659a3efef2c0abb9bea20fc89187affca16f9f Mon Sep 17 00:00:00 2001
From: Hangjie Mo <mohangjie1995@gmail.com>
Date: Wed, 27 Dec 2023 19:42:28 +0800
Subject: [PATCH] server: improve `dump.Uintxx` implementation (#49837)

close pingcap/tidb#44970
---
 pkg/server/internal/dump/dump.go | 20 +++-----------------
 1 file changed, 3 insertions(+), 17 deletions(-)

diff --git a/pkg/server/internal/dump/dump.go b/pkg/server/internal/dump/dump.go
index ea5d07272b..016d6cc1c8 100644
--- a/pkg/server/internal/dump/dump.go
+++ b/pkg/server/internal/dump/dump.go
@@ -72,31 +72,17 @@ func LengthEncodedInt(buffer []byte, n uint64) []byte {
 
 // Uint16 dumps an uint16 as byte slice.
 func Uint16(buffer []byte, n uint16) []byte {
-	buffer = append(buffer, byte(n))
-	buffer = append(buffer, byte(n>>8))
-	return buffer
+	return binary.LittleEndian.AppendUint16(buffer, n)
 }
 
 // Uint32 dumps an uint32 as byte slice.
 func Uint32(buffer []byte, n uint32) []byte {
-	buffer = append(buffer, byte(n))
-	buffer = append(buffer, byte(n>>8))
-	buffer = append(buffer, byte(n>>16))
-	buffer = append(buffer, byte(n>>24))
-	return buffer
+	return binary.LittleEndian.AppendUint32(buffer, n)
 }
 
 // Uint64 dumps an uint64 as byte slice.
 func Uint64(buffer []byte, n uint64) []byte {
-	buffer = append(buffer, byte(n))
-	buffer = append(buffer, byte(n>>8))
-	buffer = append(buffer, byte(n>>16))
-	buffer = append(buffer, byte(n>>24))
-	buffer = append(buffer, byte(n>>32))
-	buffer = append(buffer, byte(n>>40))
-	buffer = append(buffer, byte(n>>48))
-	buffer = append(buffer, byte(n>>56))
-	return buffer
+	return binary.LittleEndian.AppendUint64(buffer, n)
 }
 
 // BinaryTime dumps a time as binary byte slice.