From da5574a0678e809db3aeea2c8a250ae3011676ea Mon Sep 17 00:00:00 2001 From: Shirly Date: Sun, 25 Apr 2021 11:35:54 +0800 Subject: [PATCH] */tests: remove ineffectual assignment in tests (#24225) --- store/tikv/tests/snapshot_fail_test.go | 2 +- util/rowcodec/rowcodec_test.go | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/store/tikv/tests/snapshot_fail_test.go b/store/tikv/tests/snapshot_fail_test.go index 654eaaa53d..1fc4390c22 100644 --- a/store/tikv/tests/snapshot_fail_test.go +++ b/store/tikv/tests/snapshot_fail_test.go @@ -206,7 +206,7 @@ func (s *testSnapshotFailSuite) TestRetryPointGetResolveTS(c *C) { txn, err := s.store.Begin() c.Assert(err, IsNil) - err = txn.Set([]byte("k1"), []byte("v1")) + c.Assert(txn.Set([]byte("k1"), []byte("v1")), IsNil) err = txn.Set([]byte("k2"), []byte("v2")) c.Assert(err, IsNil) txn.SetOption(kv.EnableAsyncCommit, false) diff --git a/util/rowcodec/rowcodec_test.go b/util/rowcodec/rowcodec_test.go index 22d2b50fe2..b676127abf 100644 --- a/util/rowcodec/rowcodec_test.go +++ b/util/rowcodec/rowcodec_test.go @@ -65,9 +65,8 @@ func (s *testSuite) TestEncodeLargeSmallReuseBug(c *C) { IsPKHandle: false, }, }, nil) - m, err := bDecoder.DecodeToDatumMap(b, nil) + _, err = bDecoder.DecodeToDatumMap(b, nil) c.Assert(err, IsNil) - v := m[largeColID] colFt = types.NewFieldType(mysql.TypeLonglong) smallColID := int64(1) @@ -81,9 +80,9 @@ func (s *testSuite) TestEncodeLargeSmallReuseBug(c *C) { IsPKHandle: false, }, }, nil) - m, err = bDecoder.DecodeToDatumMap(b, nil) + m, err := bDecoder.DecodeToDatumMap(b, nil) c.Assert(err, IsNil) - v = m[smallColID] + v := m[smallColID] c.Assert(v.GetInt64(), Equals, int64(2)) }