From eda6cc31e980df8612cd870eec570e07ddd864eb Mon Sep 17 00:00:00 2001 From: Lynn Date: Mon, 25 Nov 2024 11:11:44 +0800 Subject: [PATCH] expression: remove redundant warnings when executing SUBTIME (#57508) --- pkg/executor/test/executor/executor_test.go | 1 - pkg/expression/builtin_time_vec_generated.go | 4 ---- pkg/expression/generator/time_vec.go | 2 -- 3 files changed, 7 deletions(-) diff --git a/pkg/executor/test/executor/executor_test.go b/pkg/executor/test/executor/executor_test.go index e0901c3ffa..3d012dd765 100644 --- a/pkg/executor/test/executor/executor_test.go +++ b/pkg/executor/test/executor/executor_test.go @@ -3002,7 +3002,6 @@ func TestIssue48756(t *testing.T) { )) tk.MustQuery("show warnings").Check(testkit.Rows( "Warning 1292 Incorrect time value: '120120519090607'", - "Warning 1105 ", )) } diff --git a/pkg/expression/builtin_time_vec_generated.go b/pkg/expression/builtin_time_vec_generated.go index 02b8eea262..6cb53c94e9 100644 --- a/pkg/expression/builtin_time_vec_generated.go +++ b/pkg/expression/builtin_time_vec_generated.go @@ -350,7 +350,6 @@ func (b *builtinAddStringAndDurationSig) vecEvalString(ctx EvalContext, input *c return err } if isNull { - tc.AppendWarning(err) result.AppendNull() // fixed: false continue } @@ -448,7 +447,6 @@ func (b *builtinAddStringAndStringSig) vecEvalString(ctx EvalContext, input *chu return err } if isNull { - tc.AppendWarning(err) result.AppendNull() // fixed: false continue } @@ -991,7 +989,6 @@ func (b *builtinSubStringAndDurationSig) vecEvalString(ctx EvalContext, input *c return err } if isNull { - tc.AppendWarning(err) result.AppendNull() // fixed: false continue } @@ -1089,7 +1086,6 @@ func (b *builtinSubStringAndStringSig) vecEvalString(ctx EvalContext, input *chu return err } if isNull { - tc.AppendWarning(err) result.AppendNull() // fixed: false continue } diff --git a/pkg/expression/generator/time_vec.go b/pkg/expression/generator/time_vec.go index 3f31c9f9fe..49c5e7aefa 100644 --- a/pkg/expression/generator/time_vec.go +++ b/pkg/expression/generator/time_vec.go @@ -269,7 +269,6 @@ func (b *{{.SigName}}) vecEval{{ .Output.TypeName }}(ctx EvalContext, input *chu return err } if isNull { - tc.AppendWarning(err) {{ template "SetNull" . }} continue } @@ -302,7 +301,6 @@ func (b *{{.SigName}}) vecEval{{ .Output.TypeName }}(ctx EvalContext, input *chu return err } if isNull { - tc.AppendWarning(err) {{ template "SetNull" . }} continue }