From f699bd81a24fafca6f96ea04fb5095bd9047c2ff Mon Sep 17 00:00:00 2001 From: Jack Yu Date: Tue, 15 Sep 2020 21:48:20 +0800 Subject: [PATCH] session: cleanup an useless function (#19977) --- session/session_test.go | 3 ++- session/tidb.go | 7 ------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/session/session_test.go b/session/session_test.go index b465bbd770..6a25081f7c 100644 --- a/session/session_test.go +++ b/session/session_test.go @@ -719,7 +719,8 @@ func (s *testSessionSuite) TestRetryCleanTxn(c *C) { history := session.GetHistory(tk.Se) stmtNode, err := parser.New().ParseOneStmt("insert retrytxn values (2, 'a')", "", "") c.Assert(err, IsNil) - stmt, _ := session.Compile(context.TODO(), tk.Se, stmtNode) + compiler := executor.Compiler{Ctx: tk.Se} + stmt, _ := compiler.Compile(context.TODO(), stmtNode) executor.ResetContextOfStmt(tk.Se, stmtNode) history.Add(stmt, tk.Se.GetSessionVars().StmtCtx) _, err = tk.Exec("commit") diff --git a/session/tidb.go b/session/tidb.go index c53441f419..9d319814b0 100644 --- a/session/tidb.go +++ b/session/tidb.go @@ -175,13 +175,6 @@ func Parse(ctx sessionctx.Context, src string) ([]ast.StmtNode, error) { return stmts, nil } -// Compile is safe for concurrent use by multiple goroutines. -func Compile(ctx context.Context, sctx sessionctx.Context, stmtNode ast.StmtNode) (sqlexec.Statement, error) { - compiler := executor.Compiler{Ctx: sctx} - stmt, err := compiler.Compile(ctx, stmtNode) - return stmt, err -} - func recordAbortTxnDuration(sessVars *variable.SessionVars) { duration := time.Since(sessVars.TxnCtx.CreateTime).Seconds() if sessVars.TxnCtx.IsPessimistic {