352 lines
12 KiB
Go
352 lines
12 KiB
Go
// Copyright 2023 PingCAP, Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package executor_test
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"net/url"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/pingcap/tidb/pkg/config"
|
|
"github.com/pingcap/tidb/pkg/config/kerneltype"
|
|
"github.com/pingcap/tidb/pkg/executor"
|
|
"github.com/pingcap/tidb/pkg/executor/importer"
|
|
"github.com/pingcap/tidb/pkg/kv"
|
|
"github.com/pingcap/tidb/pkg/objstore/s3like"
|
|
"github.com/pingcap/tidb/pkg/parser"
|
|
"github.com/pingcap/tidb/pkg/parser/ast"
|
|
"github.com/pingcap/tidb/pkg/parser/auth"
|
|
plannercore "github.com/pingcap/tidb/pkg/planner/core"
|
|
"github.com/pingcap/tidb/pkg/sessionctx/variable"
|
|
"github.com/pingcap/tidb/pkg/testkit"
|
|
"github.com/pingcap/tidb/pkg/testkit/testfailpoint"
|
|
"github.com/pingcap/tidb/pkg/util/dbterror/exeerrors"
|
|
"github.com/pingcap/tidb/pkg/util/dbterror/plannererrors"
|
|
semv1 "github.com/pingcap/tidb/pkg/util/sem"
|
|
semv2 "github.com/pingcap/tidb/pkg/util/sem/v2"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
var (
|
|
semTestPatternFnsFac = func(sqlRules ...string) map[string][2]func(t *testing.T, tk *testkit.TestKit) {
|
|
return map[string][2]func(t *testing.T, tk *testkit.TestKit){
|
|
"v1": {
|
|
func(t *testing.T, tk *testkit.TestKit) { semv1.Enable() },
|
|
func(t *testing.T, tk *testkit.TestKit) { semv1.Disable() },
|
|
},
|
|
"v2": {
|
|
func(t *testing.T, tk *testkit.TestKit) {
|
|
t.Helper()
|
|
// in SEM V1, "import_with_external_id", "import_from_local" are forbidden
|
|
// completely, but in SEM V2, it's taken as restricted SQL, which
|
|
// requires RESTRICTED_SQL_ADMIN privilege, when SEM enabled, root
|
|
// doesn't have this privilege by default.
|
|
// we must add this Auth as default testkit session doesn't have user
|
|
// info.
|
|
require.NoError(t, tk.Session().Auth(&auth.UserIdentity{Username: "root", Hostname: "localhost"}, nil, nil, nil))
|
|
|
|
require.NoError(t, semv2.EnableBy(&semv2.Config{TiDBVersion: "v0.0.0",
|
|
RestrictedSQL: semv2.SQLRestriction{Rule: sqlRules}}))
|
|
},
|
|
func(t *testing.T, tk *testkit.TestKit) { semv2.Disable() },
|
|
},
|
|
}
|
|
}
|
|
semTestPatternFns = semTestPatternFnsFac("import_from_local", "import_with_external_id")
|
|
)
|
|
|
|
func TestSecurityEnhancedMode(t *testing.T) {
|
|
store := testkit.CreateMockStore(t)
|
|
|
|
tk := testkit.NewTestKit(t, store)
|
|
tk.MustExec("create table test.t (id int);")
|
|
for i, fns := range semTestPatternFns {
|
|
t.Run(fmt.Sprint(i), func(t *testing.T) {
|
|
fns[0](t, tk)
|
|
t.Cleanup(func() {
|
|
fns[1](t, tk)
|
|
})
|
|
|
|
// When SEM is enabled these features are restricted to all users
|
|
// regardless of what privileges they have available.
|
|
tk.MustMatchErrMsg("IMPORT INTO test.t FROM '/file.csv'", `(?i).*Feature 'IMPORT INTO .*from.*' is not supported when security enhanced mode is enabled`)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestClassicS3ExternalID(t *testing.T) {
|
|
if kerneltype.IsNextGen() {
|
|
t.Skip("only for classic")
|
|
}
|
|
store := testkit.CreateMockStore(t)
|
|
outerTK := testkit.NewTestKit(t, store)
|
|
outerTK.MustExec("create table test.t (id int);")
|
|
|
|
bak := config.GetGlobalKeyspaceName()
|
|
config.UpdateGlobal(func(conf *config.Config) {
|
|
conf.KeyspaceName = "aaa"
|
|
})
|
|
t.Cleanup(func() {
|
|
config.UpdateGlobal(func(conf *config.Config) {
|
|
conf.KeyspaceName = bak
|
|
})
|
|
})
|
|
|
|
t.Run("SEM enabled, explicit external ID is allowed, and we don't change it", func(t *testing.T) {
|
|
for i, fns := range semTestPatternFnsFac() {
|
|
t.Run(fmt.Sprint(i), func(t *testing.T) {
|
|
tk := testkit.NewTestKit(t, store)
|
|
fns[0](t, tk)
|
|
t.Cleanup(func() {
|
|
fns[1](t, tk)
|
|
})
|
|
testfailpoint.EnableCall(t, "github.com/pingcap/tidb/pkg/executor/importer/NewImportPlan", func(plan *plannercore.ImportInto) {
|
|
u, err := url.Parse(plan.Path)
|
|
require.NoError(t, err)
|
|
require.Contains(t, u.Query(), s3like.S3ExternalID)
|
|
require.Equal(t, "allowed", u.Query().Get(s3like.S3ExternalID))
|
|
panic("FAIL IT, AS WE CANNOT RUN IT HERE")
|
|
})
|
|
tk.MustExec("IMPORT INTO test.t FROM 's3://bucket?EXTERNAL-ID=allowed'")
|
|
tk.MustQuery("select * from test.t").Check(testkit.Rows())
|
|
})
|
|
}
|
|
})
|
|
|
|
t.Run("SEM disabled, explicit external ID is also allowed, and we don't change it", func(t *testing.T) {
|
|
tk := testkit.NewTestKit(t, store)
|
|
testfailpoint.EnableCall(t, "github.com/pingcap/tidb/pkg/executor/importer/NewImportPlan", func(plan *plannercore.ImportInto) {
|
|
u, err := url.Parse(plan.Path)
|
|
require.NoError(t, err)
|
|
require.Contains(t, u.Query(), s3like.S3ExternalID)
|
|
require.Equal(t, "allowed", u.Query().Get(s3like.S3ExternalID))
|
|
panic("FAIL IT, AS WE CANNOT RUN IT HERE")
|
|
})
|
|
tk.MustExec("IMPORT INTO test.t FROM 's3://bucket?EXTERNAL-ID=allowed'")
|
|
tk.MustQuery("select * from test.t").Check(testkit.Rows())
|
|
})
|
|
}
|
|
|
|
func TestNextGenS3ExternalID(t *testing.T) {
|
|
if kerneltype.IsClassic() {
|
|
t.Skip("only for nextgen")
|
|
}
|
|
store := testkit.CreateMockStore(t)
|
|
outerTK := testkit.NewTestKit(t, store)
|
|
outerTK.MustExec("create table test.t (id int);")
|
|
|
|
t.Run("SEM enabled, forbid set S3 external ID", func(t *testing.T) {
|
|
for i, fns := range semTestPatternFns {
|
|
t.Run(fmt.Sprint(i), func(t *testing.T) {
|
|
tk := testkit.NewTestKit(t, store)
|
|
fns[0](t, tk)
|
|
t.Cleanup(func() {
|
|
fns[1](t, tk)
|
|
})
|
|
tk.MustMatchErrMsg("IMPORT INTO test.t FROM 's3://bucket?EXTERNAL-ID=abc'", `(?i).*Feature 'IMPORT INTO .*external.*' is not supported when security enhanced mode is enabled`)
|
|
})
|
|
}
|
|
})
|
|
|
|
t.Run("SEM enabled, set S3 external ID to keyspace name", func(t *testing.T) {
|
|
bak := config.GetGlobalKeyspaceName()
|
|
config.UpdateGlobal(func(conf *config.Config) {
|
|
conf.KeyspaceName = "aaa"
|
|
})
|
|
t.Cleanup(func() {
|
|
config.UpdateGlobal(func(conf *config.Config) {
|
|
conf.KeyspaceName = bak
|
|
})
|
|
})
|
|
for i, fns := range semTestPatternFns {
|
|
t.Run(fmt.Sprint(i), func(t *testing.T) {
|
|
tk := testkit.NewTestKit(t, store)
|
|
fns[0](t, tk)
|
|
t.Cleanup(func() {
|
|
fns[1](t, tk)
|
|
})
|
|
testfailpoint.EnableCall(t, "github.com/pingcap/tidb/pkg/executor/importer/NewImportPlan", func(plan *plannercore.ImportInto) {
|
|
u, err := url.Parse(plan.Path)
|
|
require.NoError(t, err)
|
|
require.Contains(t, u.Query(), s3like.S3ExternalID)
|
|
require.Equal(t, "aaa", u.Query().Get(s3like.S3ExternalID))
|
|
panic("FAIL IT, AS WE CANNOT RUN IT HERE")
|
|
})
|
|
err := tk.QueryToErr("IMPORT INTO test.t FROM 's3://bucket'")
|
|
require.ErrorContains(t, err, "FAIL IT, AS WE CANNOT RUN IT HERE")
|
|
})
|
|
}
|
|
})
|
|
|
|
t.Run("SEM disabled, allow explicit S3 external id, should not change it", func(t *testing.T) {
|
|
tk := testkit.NewTestKit(t, store)
|
|
|
|
bak := config.GetGlobalKeyspaceName()
|
|
config.UpdateGlobal(func(conf *config.Config) {
|
|
conf.KeyspaceName = "aaa"
|
|
})
|
|
t.Cleanup(func() {
|
|
config.UpdateGlobal(func(conf *config.Config) {
|
|
conf.KeyspaceName = bak
|
|
})
|
|
})
|
|
testfailpoint.EnableCall(t, "github.com/pingcap/tidb/pkg/executor/importer/NewImportPlan", func(plan *plannercore.ImportInto) {
|
|
u, err := url.Parse(plan.Path)
|
|
require.NoError(t, err)
|
|
require.Contains(t, u.Query(), s3like.S3ExternalID)
|
|
require.Equal(t, "allowed", u.Query().Get(s3like.S3ExternalID))
|
|
panic("FAIL IT, AS WE CANNOT RUN IT HERE")
|
|
})
|
|
err := tk.QueryToErr("IMPORT INTO test.t FROM 's3://bucket?external-id=allowed'")
|
|
require.ErrorContains(t, err, "FAIL IT, AS WE CANNOT RUN IT HERE")
|
|
})
|
|
}
|
|
|
|
func TestNextGenUnsupportedLocalSortAndOptions(t *testing.T) {
|
|
if kerneltype.IsClassic() {
|
|
t.Skip("only for nextgen")
|
|
}
|
|
store := testkit.CreateMockStore(t)
|
|
outerTK := testkit.NewTestKit(t, store)
|
|
outerTK.MustExec("create table test.t (id int);")
|
|
for i, fns := range semTestPatternFns {
|
|
t.Run(fmt.Sprint(i), func(t *testing.T) {
|
|
testNextGenUnsupportedLocalSortAndOptions(t, store, func(t *testing.T, tk *testkit.TestKit) {
|
|
fns[0](t, tk)
|
|
t.Cleanup(func() {
|
|
fns[1](t, tk)
|
|
})
|
|
})
|
|
})
|
|
}
|
|
}
|
|
|
|
func testNextGenUnsupportedLocalSortAndOptions(t *testing.T, store kv.Storage, initFn func(t *testing.T, tk *testkit.TestKit)) {
|
|
t.Run("import from select", func(t *testing.T) {
|
|
tk := testkit.NewTestKit(t, store)
|
|
initFn(t, tk)
|
|
err := tk.ExecToErr("IMPORT INTO test.t FROM select 1")
|
|
require.ErrorIs(t, err, plannererrors.ErrNotSupportedWithSem)
|
|
require.ErrorContains(t, err, "IMPORT INTO from select")
|
|
})
|
|
|
|
t.Run("local sort", func(t *testing.T) {
|
|
tk := testkit.NewTestKit(t, store)
|
|
initFn(t, tk)
|
|
err := tk.QueryToErr("IMPORT INTO test.t FROM 's3://bucket/*.csv'")
|
|
require.ErrorIs(t, err, plannererrors.ErrNotSupportedWithSem)
|
|
require.ErrorContains(t, err, "IMPORT INTO with local sort")
|
|
})
|
|
|
|
t.Run("unsupported options", func(t *testing.T) {
|
|
tk := testkit.NewTestKit(t, store)
|
|
initFn(t, tk)
|
|
bak := variable.ValidateCloudStorageURI
|
|
variable.ValidateCloudStorageURI = func(ctx context.Context, uri string) error {
|
|
return nil
|
|
}
|
|
t.Cleanup(func() {
|
|
variable.ValidateCloudStorageURI = bak
|
|
})
|
|
tk.MustExec("set global tidb_cloud_storage_uri='s3://bucket/tmp'")
|
|
t.Cleanup(func() {
|
|
tk.MustExec("set global tidb_cloud_storage_uri=''")
|
|
})
|
|
for _, option := range []string{
|
|
"disk_quota",
|
|
"max_write_speed",
|
|
"cloud_storage_uri",
|
|
"thread",
|
|
"__max_engine_size",
|
|
"checksum_table",
|
|
"record_errors",
|
|
} {
|
|
err := tk.QueryToErr(fmt.Sprintf("IMPORT INTO test.t FROM 's3://bucket/*.csv' with %s='1'", option))
|
|
require.ErrorIs(t, err, exeerrors.ErrLoadDataUnsupportedOption)
|
|
require.ErrorContains(t, err, option)
|
|
}
|
|
for _, option := range []string{
|
|
"__force_merge_step",
|
|
"__manual_recovery",
|
|
} {
|
|
err := tk.QueryToErr(fmt.Sprintf("IMPORT INTO test.t FROM 's3://bucket/*.csv' with %s", option))
|
|
require.ErrorIs(t, err, exeerrors.ErrLoadDataUnsupportedOption)
|
|
require.ErrorContains(t, err, option)
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestImportIntoValidateColAssignmentsWithEncodeCtx(t *testing.T) {
|
|
cases := []struct {
|
|
exprs []string
|
|
error string
|
|
}{
|
|
{
|
|
exprs: []string{"'x'", "1+@1", "concat('hello', 'world')", "getvar('var1')"},
|
|
},
|
|
{
|
|
exprs: []string{"setvar('a', 'b')"},
|
|
error: "FUNCTION setvar is not supported in IMPORT INTO column assignment, index 0",
|
|
},
|
|
{
|
|
exprs: []string{"current_user()"},
|
|
error: "FUNCTION current_user is not supported in IMPORT INTO column assignment, index 0",
|
|
},
|
|
{
|
|
exprs: []string{"current_role()"},
|
|
error: "FUNCTION current_role is not supported in IMPORT INTO column assignment, index 0",
|
|
},
|
|
{
|
|
exprs: []string{"connection_id()"},
|
|
error: "FUNCTION connection_id is not supported in IMPORT INTO column assignment, index 0",
|
|
},
|
|
{
|
|
exprs: []string{"1", "tidb_is_ddl_owner()"},
|
|
error: "FUNCTION tidb_is_ddl_owner is not supported in IMPORT INTO column assignment, index 1",
|
|
},
|
|
{
|
|
exprs: []string{"sleep(1)"},
|
|
error: "FUNCTION sleep is not supported in IMPORT INTO column assignment, index 0",
|
|
},
|
|
{
|
|
exprs: []string{"LAST_INSERT_ID()"},
|
|
error: "FUNCTION last_insert_id is not supported in IMPORT INTO column assignment, index 0",
|
|
},
|
|
}
|
|
|
|
for i, c := range cases {
|
|
t.Run(fmt.Sprintf("case-%d-%s", i, strings.Join(c.exprs, ",")), func(t *testing.T) {
|
|
assigns := make([]*ast.Assignment, 0, len(c.exprs))
|
|
for _, exprStr := range c.exprs {
|
|
stmt, err := parser.New().ParseOneStmt("select "+exprStr, "", "")
|
|
require.NoError(t, err)
|
|
expr := stmt.(*ast.SelectStmt).Fields.Fields[0].Expr
|
|
assigns = append(assigns, &ast.Assignment{
|
|
Expr: expr,
|
|
})
|
|
}
|
|
|
|
err := executor.ValidateImportIntoColAssignmentsWithEncodeCtx(&importer.Plan{}, assigns)
|
|
if c.error == "" {
|
|
require.NoError(t, err)
|
|
} else {
|
|
require.EqualError(t, err, c.error)
|
|
}
|
|
})
|
|
}
|
|
}
|