Files
tidb/pkg/ddl/table_test.go

743 lines
24 KiB
Go

// Copyright 2015 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package ddl_test
import (
"context"
"fmt"
"sync"
"sync/atomic"
"testing"
"time"
"github.com/pingcap/errors"
"github.com/pingcap/tidb/pkg/ddl"
"github.com/pingcap/tidb/pkg/ddl/util/callback"
"github.com/pingcap/tidb/pkg/infoschema"
"github.com/pingcap/tidb/pkg/kv"
"github.com/pingcap/tidb/pkg/meta"
"github.com/pingcap/tidb/pkg/meta/autoid"
"github.com/pingcap/tidb/pkg/parser/ast"
"github.com/pingcap/tidb/pkg/parser/model"
"github.com/pingcap/tidb/pkg/parser/mysql"
"github.com/pingcap/tidb/pkg/sessionctx"
"github.com/pingcap/tidb/pkg/sessiontxn"
"github.com/pingcap/tidb/pkg/table"
"github.com/pingcap/tidb/pkg/testkit"
"github.com/pingcap/tidb/pkg/testkit/testfailpoint"
"github.com/pingcap/tidb/pkg/types"
"github.com/pingcap/tidb/pkg/util"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func testRenameTable(
t *testing.T,
ctx sessionctx.Context,
d ddl.DDL,
newSchemaID, oldSchemaID int64,
oldSchemaName model.CIStr,
newSchemaName model.CIStr,
tblInfo *model.TableInfo,
) *model.Job {
job := &model.Job{
SchemaID: newSchemaID,
TableID: tblInfo.ID,
Type: model.ActionRenameTable,
BinlogInfo: &model.HistoryInfo{},
Args: []any{oldSchemaID, tblInfo.Name, oldSchemaName},
CtxVars: []any{[]int64{oldSchemaID, newSchemaID}, []int64{tblInfo.ID}},
InvolvingSchemaInfo: []model.InvolvingSchemaInfo{
{Database: oldSchemaName.L, Table: tblInfo.Name.L},
{Database: newSchemaName.L, Table: tblInfo.Name.L},
},
}
ctx.SetValue(sessionctx.QueryString, "skip")
require.NoError(t, d.DoDDLJobWrapper(ctx, ddl.NewJobWrapper(job, true)))
v := getSchemaVer(t, ctx)
tblInfo.State = model.StatePublic
checkHistoryJobArgs(t, ctx, job.ID, &historyJobArgs{ver: v, tbl: tblInfo})
tblInfo.State = model.StateNone
return job
}
func testRenameTables(t *testing.T, ctx sessionctx.Context, d ddl.DDL, oldSchemaIDs, newSchemaIDs []int64, newTableNames []*model.CIStr, oldTableIDs []int64, oldSchemaNames, oldTableNames []*model.CIStr) *model.Job {
job := &model.Job{
Type: model.ActionRenameTables,
BinlogInfo: &model.HistoryInfo{},
Args: []any{oldSchemaIDs, newSchemaIDs, newTableNames, oldTableIDs, oldSchemaNames, oldTableNames},
CtxVars: []any{append(oldSchemaIDs, newSchemaIDs...), oldTableIDs},
InvolvingSchemaInfo: []model.InvolvingSchemaInfo{
{Database: oldSchemaNames[0].L, Table: oldTableNames[0].L},
{Database: oldSchemaNames[0].L, Table: newTableNames[0].L},
},
}
ctx.SetValue(sessionctx.QueryString, "skip")
require.NoError(t, d.DoDDLJobWrapper(ctx, ddl.NewJobWrapper(job, true)))
v := getSchemaVer(t, ctx)
checkHistoryJobArgs(t, ctx, job.ID, &historyJobArgs{ver: v, tbl: nil})
return job
}
func testLockTable(
t *testing.T,
ctx sessionctx.Context,
d ddl.DDL,
newSchemaID int64,
schemaName model.CIStr,
tblInfo *model.TableInfo,
lockTp model.TableLockType,
) *model.Job {
arg := &ddl.LockTablesArg{
LockTables: []model.TableLockTpInfo{{SchemaID: newSchemaID, TableID: tblInfo.ID, Tp: lockTp}},
SessionInfo: model.SessionInfo{
ServerID: d.GetID(),
SessionID: ctx.GetSessionVars().ConnectionID,
},
}
job := &model.Job{
SchemaID: newSchemaID,
TableID: tblInfo.ID,
Type: model.ActionLockTable,
BinlogInfo: &model.HistoryInfo{},
Args: []any{arg},
InvolvingSchemaInfo: []model.InvolvingSchemaInfo{
{Database: schemaName.L, Table: tblInfo.Name.L},
},
}
ctx.SetValue(sessionctx.QueryString, "skip")
err := d.DoDDLJobWrapper(ctx, ddl.NewJobWrapper(job, true))
require.NoError(t, err)
v := getSchemaVer(t, ctx)
checkHistoryJobArgs(t, ctx, job.ID, &historyJobArgs{ver: v})
return job
}
func checkTableLockedTest(t *testing.T, store kv.Storage, dbInfo *model.DBInfo, tblInfo *model.TableInfo, serverID string, sessionID uint64, lockTp model.TableLockType) {
ctx := kv.WithInternalSourceType(context.Background(), kv.InternalTxnDDL)
err := kv.RunInNewTxn(ctx, store, false, func(ctx context.Context, txn kv.Transaction) error {
tt := meta.NewMeta(txn)
info, err := tt.GetTable(dbInfo.ID, tblInfo.ID)
require.NoError(t, err)
require.NotNil(t, info)
require.NotNil(t, info.Lock)
require.Len(t, info.Lock.Sessions, 1)
require.Equal(t, serverID, info.Lock.Sessions[0].ServerID)
require.Equal(t, sessionID, info.Lock.Sessions[0].SessionID)
require.Equal(t, lockTp, info.Lock.Tp)
require.Equal(t, lockTp, info.Lock.Tp)
require.Equal(t, model.TableLockStatePublic, info.Lock.State)
return nil
})
require.NoError(t, err)
}
func testTruncateTable(t *testing.T, ctx sessionctx.Context, store kv.Storage, d ddl.DDL, dbInfo *model.DBInfo, tblInfo *model.TableInfo) *model.Job {
genIDs, err := genGlobalIDs(store, 1)
require.NoError(t, err)
newTableID := genIDs[0]
job := &model.Job{
SchemaID: dbInfo.ID,
SchemaName: dbInfo.Name.L,
TableID: tblInfo.ID,
TableName: tblInfo.Name.L,
Type: model.ActionTruncateTable,
BinlogInfo: &model.HistoryInfo{},
Args: []any{newTableID},
}
ctx.SetValue(sessionctx.QueryString, "skip")
err = d.DoDDLJobWrapper(ctx, ddl.NewJobWrapper(job, true))
require.NoError(t, err)
v := getSchemaVer(t, ctx)
tblInfo.ID = newTableID
checkHistoryJobArgs(t, ctx, job.ID, &historyJobArgs{ver: v, tbl: tblInfo})
return job
}
func testGetTableWithError(r autoid.Requirement, schemaID, tableID int64) (table.Table, error) {
var tblInfo *model.TableInfo
ctx := kv.WithInternalSourceType(context.Background(), kv.InternalTxnDDL)
err := kv.RunInNewTxn(ctx, r.Store(), false, func(ctx context.Context, txn kv.Transaction) error {
t := meta.NewMeta(txn)
var err1 error
tblInfo, err1 = t.GetTable(schemaID, tableID)
if err1 != nil {
return errors.Trace(err1)
}
return nil
})
if err != nil {
return nil, errors.Trace(err)
}
if tblInfo == nil {
return nil, errors.New("table not found")
}
alloc := autoid.NewAllocator(r, schemaID, tblInfo.ID, false, autoid.RowIDAllocType)
tbl, err := table.TableFromMeta(autoid.NewAllocators(false, alloc), tblInfo)
if err != nil {
return nil, errors.Trace(err)
}
return tbl, nil
}
func TestTable(t *testing.T) {
store, domain := testkit.CreateMockStoreAndDomainWithSchemaLease(t, testLease)
d := domain.DDL()
dbInfo, err := testSchemaInfo(store, "test_table")
require.NoError(t, err)
testCreateSchema(t, testkit.NewTestKit(t, store).Session(), domain.DDL(), dbInfo)
ctx := testkit.NewTestKit(t, store).Session()
tblInfo, err := testTableInfo(store, "t", 3)
require.NoError(t, err)
job := testCreateTable(t, ctx, d, dbInfo, tblInfo)
testCheckTableState(t, store, dbInfo, tblInfo, model.StatePublic)
testCheckJobDone(t, store, job.ID, true)
// Create an existing table.
newTblInfo, err := testTableInfo(store, "t", 3)
require.NoError(t, err)
doDDLJobErr(t, dbInfo.ID, newTblInfo.ID, dbInfo.Name.L, newTblInfo.Name.L, model.ActionCreateTable, []any{newTblInfo}, ctx, d, store)
ctx = testkit.NewTestKit(t, store).Session()
require.NoError(t, sessiontxn.NewTxn(context.Background(), ctx))
count := 2000
tbl := testGetTable(t, domain, tblInfo.ID)
for i := 1; i <= count; i++ {
_, err := tbl.AddRecord(ctx.GetTableCtx(), types.MakeDatums(i, i, i))
require.NoError(t, err)
}
require.NoError(t, ctx.CommitTxn(context.Background()))
jobID := testDropTable(testkit.NewTestKit(t, store), t, dbInfo.Name.L, tblInfo.Name.L, domain)
testCheckJobDone(t, store, jobID, false)
// for truncate table
tblInfo, err = testTableInfo(store, "tt", 3)
require.NoError(t, err)
job = testCreateTable(t, ctx, d, dbInfo, tblInfo)
testCheckTableState(t, store, dbInfo, tblInfo, model.StatePublic)
testCheckJobDone(t, store, job.ID, true)
job = testTruncateTable(t, ctx, store, d, dbInfo, tblInfo)
testCheckTableState(t, store, dbInfo, tblInfo, model.StatePublic)
testCheckJobDone(t, store, job.ID, true)
// for rename table
dbInfo1, err := testSchemaInfo(store, "test_rename_table")
require.NoError(t, err)
testCreateSchema(t, testkit.NewTestKit(t, store).Session(), d, dbInfo1)
job = testRenameTable(t, ctx, d, dbInfo1.ID, dbInfo.ID, dbInfo.Name, dbInfo1.Name, tblInfo)
testCheckTableState(t, store, dbInfo1, tblInfo, model.StatePublic)
testCheckJobDone(t, store, job.ID, true)
job = testLockTable(t, ctx, d, dbInfo1.ID, dbInfo1.Name, tblInfo, model.TableLockWrite)
testCheckTableState(t, store, dbInfo1, tblInfo, model.StatePublic)
testCheckJobDone(t, store, job.ID, true)
checkTableLockedTest(t, store, dbInfo1, tblInfo, d.GetID(), ctx.GetSessionVars().ConnectionID, model.TableLockWrite)
// for alter cache table
job = testAlterCacheTable(t, ctx, d, dbInfo1.ID, dbInfo1.Name, tblInfo)
testCheckTableState(t, store, dbInfo1, tblInfo, model.StatePublic)
testCheckJobDone(t, store, job.ID, true)
checkTableCacheTest(t, store, dbInfo1, tblInfo)
// for alter no cache table
job = testAlterNoCacheTable(t, ctx, d, dbInfo1.ID, dbInfo1.Name, tblInfo)
testCheckTableState(t, store, dbInfo1, tblInfo, model.StatePublic)
testCheckJobDone(t, store, job.ID, true)
checkTableNoCacheTest(t, store, dbInfo1, tblInfo)
testDropSchema(t, testkit.NewTestKit(t, store).Session(), d, dbInfo)
}
func TestCreateView(t *testing.T) {
store, domain := testkit.CreateMockStoreAndDomainWithSchemaLease(t, testLease)
d := domain.DDL()
dbInfo, err := testSchemaInfo(store, "test_table")
require.NoError(t, err)
testCreateSchema(t, testkit.NewTestKit(t, store).Session(), domain.DDL(), dbInfo)
ctx := testkit.NewTestKit(t, store).Session()
tblInfo, err := testTableInfo(store, "t", 3)
require.NoError(t, err)
job := testCreateTable(t, ctx, d, dbInfo, tblInfo)
testCheckTableState(t, store, dbInfo, tblInfo, model.StatePublic)
testCheckJobDone(t, store, job.ID, true)
// Create a view
newTblInfo0, err := testTableInfo(store, "v", 3)
require.NoError(t, err)
job = &model.Job{
SchemaID: dbInfo.ID,
SchemaName: dbInfo.Name.L,
TableID: tblInfo.ID,
TableName: tblInfo.Name.L,
Type: model.ActionCreateView,
BinlogInfo: &model.HistoryInfo{},
Args: []any{newTblInfo0},
}
ctx.SetValue(sessionctx.QueryString, "skip")
err = d.DoDDLJobWrapper(ctx, ddl.NewJobWrapper(job, true))
require.NoError(t, err)
v := getSchemaVer(t, ctx)
tblInfo.State = model.StatePublic
checkHistoryJobArgs(t, ctx, job.ID, &historyJobArgs{ver: v, tbl: newTblInfo0})
tblInfo.State = model.StateNone
testCheckTableState(t, store, dbInfo, tblInfo, model.StatePublic)
testCheckJobDone(t, store, job.ID, true)
// Replace a view
newTblInfo1, err := testTableInfo(store, "v", 3)
require.NoError(t, err)
job = &model.Job{
SchemaID: dbInfo.ID,
SchemaName: dbInfo.Name.L,
TableID: tblInfo.ID,
TableName: tblInfo.Name.L,
Type: model.ActionCreateView,
BinlogInfo: &model.HistoryInfo{},
Args: []any{newTblInfo1, true, newTblInfo0.ID},
}
ctx.SetValue(sessionctx.QueryString, "skip")
err = d.DoDDLJobWrapper(ctx, ddl.NewJobWrapper(job, true))
require.NoError(t, err)
v = getSchemaVer(t, ctx)
tblInfo.State = model.StatePublic
checkHistoryJobArgs(t, ctx, job.ID, &historyJobArgs{ver: v, tbl: newTblInfo1})
tblInfo.State = model.StateNone
testCheckTableState(t, store, dbInfo, tblInfo, model.StatePublic)
testCheckJobDone(t, store, job.ID, true)
// Replace a view with a non-existing table id
newTblInfo2, err := testTableInfo(store, "v", 3)
require.NoError(t, err)
job = &model.Job{
SchemaID: dbInfo.ID,
SchemaName: dbInfo.Name.L,
TableID: tblInfo.ID,
TableName: tblInfo.Name.L,
Type: model.ActionCreateView,
BinlogInfo: &model.HistoryInfo{},
Args: []any{newTblInfo2, true, newTblInfo0.ID},
}
ctx.SetValue(sessionctx.QueryString, "skip")
err = d.DoDDLJobWrapper(ctx, ddl.NewJobWrapper(job, true))
// The non-existing table id in job args will not be considered anymore.
require.NoError(t, err)
}
func checkTableCacheTest(t *testing.T, store kv.Storage, dbInfo *model.DBInfo, tblInfo *model.TableInfo) {
ctx := kv.WithInternalSourceType(context.Background(), kv.InternalTxnDDL)
require.NoError(t, kv.RunInNewTxn(ctx, store, false, func(ctx context.Context, txn kv.Transaction) error {
tt := meta.NewMeta(txn)
info, err := tt.GetTable(dbInfo.ID, tblInfo.ID)
require.NoError(t, err)
require.NotNil(t, info)
require.NotNil(t, info.TableCacheStatusType)
require.Equal(t, model.TableCacheStatusEnable, info.TableCacheStatusType)
return nil
}))
}
func checkTableNoCacheTest(t *testing.T, store kv.Storage, dbInfo *model.DBInfo, tblInfo *model.TableInfo) {
ctx := kv.WithInternalSourceType(context.Background(), kv.InternalTxnDDL)
require.NoError(t, kv.RunInNewTxn(ctx, store, false, func(ctx context.Context, txn kv.Transaction) error {
tt := meta.NewMeta(txn)
info, err := tt.GetTable(dbInfo.ID, tblInfo.ID)
require.NoError(t, err)
require.NotNil(t, info)
require.Equal(t, model.TableCacheStatusDisable, info.TableCacheStatusType)
return nil
}))
}
func testAlterCacheTable(
t *testing.T,
ctx sessionctx.Context,
d ddl.DDL,
newSchemaID int64,
newSchemaName model.CIStr,
tblInfo *model.TableInfo,
) *model.Job {
job := &model.Job{
SchemaID: newSchemaID,
TableID: tblInfo.ID,
Type: model.ActionAlterCacheTable,
BinlogInfo: &model.HistoryInfo{},
Args: []any{},
InvolvingSchemaInfo: []model.InvolvingSchemaInfo{
{Database: newSchemaName.L, Table: tblInfo.Name.L},
},
}
ctx.SetValue(sessionctx.QueryString, "skip")
err := d.DoDDLJobWrapper(ctx, ddl.NewJobWrapper(job, true))
require.NoError(t, err)
v := getSchemaVer(t, ctx)
checkHistoryJobArgs(t, ctx, job.ID, &historyJobArgs{ver: v})
return job
}
func testAlterNoCacheTable(
t *testing.T,
ctx sessionctx.Context,
d ddl.DDL,
newSchemaID int64,
newSchemaName model.CIStr,
tblInfo *model.TableInfo,
) *model.Job {
job := &model.Job{
SchemaID: newSchemaID,
TableID: tblInfo.ID,
Type: model.ActionAlterNoCacheTable,
BinlogInfo: &model.HistoryInfo{},
Args: []any{},
InvolvingSchemaInfo: []model.InvolvingSchemaInfo{
{Database: newSchemaName.L, Table: tblInfo.Name.L},
},
}
ctx.SetValue(sessionctx.QueryString, "skip")
require.NoError(t, d.DoDDLJobWrapper(ctx, ddl.NewJobWrapper(job, true)))
v := getSchemaVer(t, ctx)
checkHistoryJobArgs(t, ctx, job.ID, &historyJobArgs{ver: v})
return job
}
func TestRenameTables(t *testing.T) {
store, domain := testkit.CreateMockStoreAndDomainWithSchemaLease(t, testLease)
d := domain.DDL()
dbInfo, err := testSchemaInfo(store, "test_table")
require.NoError(t, err)
testCreateSchema(t, testkit.NewTestKit(t, store).Session(), d, dbInfo)
ctx := testkit.NewTestKit(t, store).Session()
var tblInfos = make([]*model.TableInfo, 0, 2)
var newTblInfos = make([]*model.TableInfo, 0, 2)
for i := 1; i < 3; i++ {
tableName := fmt.Sprintf("t%d", i)
tblInfo, err := testTableInfo(store, tableName, 3)
require.NoError(t, err)
job := testCreateTable(t, ctx, d, dbInfo, tblInfo)
testCheckTableState(t, store, dbInfo, tblInfo, model.StatePublic)
testCheckJobDone(t, store, job.ID, true)
tblInfos = append(tblInfos, tblInfo)
newTableName := fmt.Sprintf("tt%d", i)
tblInfo, err = testTableInfo(store, newTableName, 3)
require.NoError(t, err)
newTblInfos = append(newTblInfos, tblInfo)
}
job := testRenameTables(t, ctx, d, []int64{dbInfo.ID, dbInfo.ID}, []int64{dbInfo.ID, dbInfo.ID}, []*model.CIStr{&newTblInfos[0].Name, &newTblInfos[1].Name}, []int64{tblInfos[0].ID, tblInfos[1].ID}, []*model.CIStr{&dbInfo.Name, &dbInfo.Name}, []*model.CIStr{&tblInfos[0].Name, &tblInfos[1].Name})
historyJob, err := ddl.GetHistoryJobByID(testkit.NewTestKit(t, store).Session(), job.ID)
require.NoError(t, err)
wantTblInfos := historyJob.BinlogInfo.MultipleTableInfos
require.Equal(t, wantTblInfos[0].Name.L, "tt1")
require.Equal(t, wantTblInfos[1].Name.L, "tt2")
}
func TestCreateTables(t *testing.T) {
store, domain := testkit.CreateMockStoreAndDomainWithSchemaLease(t, testLease)
d := domain.DDL()
dbInfo, err := testSchemaInfo(store, "test_table")
require.NoError(t, err)
testCreateSchema(t, testkit.NewTestKit(t, store).Session(), d, dbInfo)
ctx := testkit.NewTestKit(t, store).Session()
var infos []*model.TableInfo
genIDs, err := genGlobalIDs(store, 3)
require.NoError(t, err)
infos = append(infos, &model.TableInfo{
ID: genIDs[0],
Name: model.NewCIStr("s1"),
})
infos = append(infos, &model.TableInfo{
ID: genIDs[1],
Name: model.NewCIStr("s2"),
})
infos = append(infos, &model.TableInfo{
ID: genIDs[2],
Name: model.NewCIStr("s3"),
})
job := &model.Job{
SchemaID: dbInfo.ID,
Type: model.ActionCreateTables,
BinlogInfo: &model.HistoryInfo{},
Args: []any{infos},
InvolvingSchemaInfo: []model.InvolvingSchemaInfo{
{Database: "test_table", Table: "s1"},
{Database: "test_table", Table: "s2"},
{Database: "test_table", Table: "s3"},
},
}
ctx.SetValue(sessionctx.QueryString, "skip")
var once sync.Once
testfailpoint.EnableCall(t, "github.com/pingcap/tidb/pkg/ddl/mockGetJobByIDFail", func(errP *error) {
once.Do(func() {
*errP = errors.New("mock get job by ID failed")
})
})
err = d.DoDDLJobWrapper(ctx, ddl.NewJobWrapper(job, true))
require.NoError(t, err)
testGetTable(t, domain, genIDs[0])
testGetTable(t, domain, genIDs[1])
testGetTable(t, domain, genIDs[2])
}
func TestAlterTTL(t *testing.T) {
store, domain := testkit.CreateMockStoreAndDomainWithSchemaLease(t, testLease)
d := domain.DDL()
dbInfo, err := testSchemaInfo(store, "test_table")
require.NoError(t, err)
testCreateSchema(t, testkit.NewTestKit(t, store).Session(), d, dbInfo)
ctx := testkit.NewTestKit(t, store).Session()
// initialize a table with ttlInfo
tableName := "t"
tblInfo, err := testTableInfo(store, tableName, 2)
require.NoError(t, err)
tblInfo.Columns[0].FieldType = *types.NewFieldType(mysql.TypeDatetime)
tblInfo.Columns[1].FieldType = *types.NewFieldType(mysql.TypeDatetime)
tblInfo.TTLInfo = &model.TTLInfo{
ColumnName: tblInfo.Columns[0].Name,
IntervalExprStr: "5",
IntervalTimeUnit: int(ast.TimeUnitDay),
}
// create table
job := testCreateTable(t, ctx, d, dbInfo, tblInfo)
testCheckTableState(t, store, dbInfo, tblInfo, model.StatePublic)
testCheckJobDone(t, store, job.ID, true)
// submit ddl job to modify ttlInfo
tableInfoAfterAlterTTLInfo := tblInfo.Clone()
require.NoError(t, err)
tableInfoAfterAlterTTLInfo.TTLInfo = &model.TTLInfo{
ColumnName: tblInfo.Columns[1].Name,
IntervalExprStr: "1",
IntervalTimeUnit: int(ast.TimeUnitYear),
}
job = &model.Job{
SchemaID: dbInfo.ID,
SchemaName: dbInfo.Name.L,
TableID: tblInfo.ID,
TableName: tblInfo.Name.L,
Type: model.ActionAlterTTLInfo,
BinlogInfo: &model.HistoryInfo{},
Args: []any{&model.TTLInfo{
ColumnName: tblInfo.Columns[1].Name,
IntervalExprStr: "1",
IntervalTimeUnit: int(ast.TimeUnitYear),
}},
}
ctx.SetValue(sessionctx.QueryString, "skip")
require.NoError(t, d.DoDDLJobWrapper(ctx, ddl.NewJobWrapper(job, true)))
v := getSchemaVer(t, ctx)
checkHistoryJobArgs(t, ctx, job.ID, &historyJobArgs{ver: v, tbl: nil})
// assert the ddlInfo as expected
historyJob, err := ddl.GetHistoryJobByID(testkit.NewTestKit(t, store).Session(), job.ID)
require.NoError(t, err)
require.Equal(t, tableInfoAfterAlterTTLInfo.TTLInfo, historyJob.BinlogInfo.TableInfo.TTLInfo)
// submit a ddl job to modify ttlEnabled
job = &model.Job{
SchemaID: dbInfo.ID,
SchemaName: dbInfo.Name.L,
TableID: tblInfo.ID,
TableName: tblInfo.Name.L,
Type: model.ActionAlterTTLRemove,
BinlogInfo: &model.HistoryInfo{},
Args: []any{true},
}
ctx.SetValue(sessionctx.QueryString, "skip")
require.NoError(t, d.DoDDLJobWrapper(ctx, ddl.NewJobWrapper(job, true)))
v = getSchemaVer(t, ctx)
checkHistoryJobArgs(t, ctx, job.ID, &historyJobArgs{ver: v, tbl: nil})
// assert the ddlInfo as expected
historyJob, err = ddl.GetHistoryJobByID(testkit.NewTestKit(t, store).Session(), job.ID)
require.NoError(t, err)
require.Empty(t, historyJob.BinlogInfo.TableInfo.TTLInfo)
}
func TestRenameTableIntermediateState(t *testing.T) {
store, dom := testkit.CreateMockStoreAndDomain(t)
tk := testkit.NewTestKit(t, store)
tk2 := testkit.NewTestKit(t, store)
originHook := dom.DDL().GetHook()
tk.MustExec("create database db1;")
tk.MustExec("create database db2;")
tk.MustExec("create table db1.t(a int);")
testCases := []struct {
renameSQL string
insertSQL string
errMsg string
finalDB string
}{
{"rename table db1.t to db1.t1;", "insert into db1.t values(1);", "[schema:1146]Table 'db1.t' doesn't exist", "db1.t1"},
{"rename table db1.t1 to db1.t;", "insert into db1.t values(1);", "", "db1.t"},
{"rename table db1.t to db2.t;", "insert into db1.t values(1);", "[schema:1146]Table 'db1.t' doesn't exist", "db2.t"},
{"rename table db2.t to db1.t;", "insert into db1.t values(1);", "", "db1.t"},
}
var finishedJobID int64
for _, tc := range testCases {
hook := &callback.TestDDLCallback{Do: dom}
runInsert := false
var jobID int64 = 0
fn := func(job *model.Job) {
if job.ID <= finishedJobID {
// The job has been done, OnJobUpdated may be invoked later asynchronously.
// We should skip the done job.
return
}
if job.Type == model.ActionRenameTable &&
job.SchemaState == model.StatePublic && !runInsert && !t.Failed() {
_, err := tk2.Exec(tc.insertSQL)
// In rename table intermediate state, new table is public.
if len(tc.errMsg) > 0 {
// Old table should not be visible to DML.
assert.NotNil(t, err)
assert.Equal(t, tc.errMsg, err.Error())
} else {
// New table should be visible to DML.
assert.NoError(t, err)
}
runInsert = true
jobID = job.ID
}
}
hook.OnJobUpdatedExported.Store(&fn)
dom.DDL().SetHook(hook)
tk.MustExec(tc.renameSQL)
result := tk.MustQuery(fmt.Sprintf("select * from %s;", tc.finalDB))
if len(tc.errMsg) > 0 {
result.Check(testkit.Rows())
} else {
result.Check(testkit.Rows("1"))
}
tk.MustExec(fmt.Sprintf("delete from %s;", tc.finalDB))
finishedJobID = jobID
}
dom.DDL().SetHook(originHook)
}
func TestCreateSameTableOrDBOnOwnerChange(t *testing.T) {
tc := testkit.NewDistExecutionContext(t, 2)
defer tc.Close()
// keep trigger owner change every 50ms.
var ownerWg util.WaitGroupWrapper
var finished atomic.Bool
ownerWg.Run(func() {
for !finished.Load() {
tc.TriggerOwnerChange()
time.Sleep(50 * time.Millisecond)
}
})
var pauseSchedule atomic.Bool
var waitSchCh = make(chan struct{})
testfailpoint.EnableCall(t, "github.com/pingcap/tidb/pkg/ddl/beforeLoadAndDeliverJobs", func() {
if pauseSchedule.Load() {
<-waitSchCh
}
})
pauseSchedule.Store(true)
var enableWaitSubmit atomic.Bool
waitSubmitCh := make(chan struct{})
testfailpoint.EnableCall(t, "github.com/pingcap/tidb/pkg/ddl/waitJobSubmitted",
func() {
if enableWaitSubmit.Load() {
<-waitSubmitCh
}
},
)
enableWaitSubmit.Store(true)
testfailpoint.EnableCall(t, "github.com/pingcap/tidb/pkg/ddl/beforeRunOneJobStep", func() { time.Sleep(300 * time.Millisecond) })
// create and wait all jobs are submitted to tidb_ddl_job before they are run.
// we are creating same table/database, only the first will success.
var wg util.WaitGroupWrapper
for gi, g := range [][]string{
{
"create table test.t(a int)",
"create table test.t(a int)",
"create table test.t(a int)",
},
{
"create database aaa",
"create database aaa",
"create database aaa",
},
} {
expectedErr := infoschema.ErrTableExists
if gi == 1 {
expectedErr = infoschema.ErrDatabaseExists
}
for i, s := range g {
idx, sql := i, s
wg.Run(func() {
tk2 := testkit.NewTestKit(t, tc.Store)
if idx == 0 {
tk2.MustExec(sql)
} else {
err := tk2.ExecToErr(sql)
require.ErrorIs(t, err, expectedErr)
}
})
waitSubmitCh <- struct{}{}
}
}
enableWaitSubmit.Store(false)
// start schedule jobs when all jobs are submitted to tidb_ddl_job
pauseSchedule.Store(false)
close(waitSchCh)
wg.Wait()
finished.Store(true)
ownerWg.Wait()
}