Greg Weber 931ff98df5 simple fixes for the staticcheck linter (#18923) ...

Note that this found 2 bugs where errors were being silently ignored.

These are really simple fixes that didn't require much thought.
There are still more staticcheck warnings that should be fixed.

Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>

2020-08-06 13:38:17 +08:00

..

agg_to_pb_test.go

planner: push aggregation functions with distinct to cop (#15500)

2020-04-01 20:49:14 +08:00

agg_to_pb.go

simple fixes for the staticcheck linter (#18923)

2020-08-06 13:38:17 +08:00

aggregation_test.go

*: let baseFuncDesc.typeInfer return error instead of panic (#10910)

2019-06-24 13:09:14 +08:00

aggregation.go

executor: add new agg function APPROX_COUNT_DISTINCT (#17175)

2020-06-18 22:00:14 +08:00

avg.go

util: revert util/mathutil (#14744)

2020-02-13 11:33:04 +08:00

base_func_test.go

expression: remove the NotNullFlag for aggregation func MAX/MIN when inferring type (#11343)

2019-08-05 17:41:40 +08:00

base_func.go

executor: fix sum & avg on year type (#18318)

2020-07-02 11:51:24 +08:00

bench_test.go

*: let baseFuncDesc.typeInfer return error instead of panic (#10910)

2019-06-24 13:09:14 +08:00

bit_and.go

expression: remove redundant "errors.Trace()" in "expression" package (#8609)

2018-12-07 12:20:31 +08:00

bit_or.go

expression: remove redundant "errors.Trace()" in "expression" package (#8609)

2018-12-07 12:20:31 +08:00

bit_xor.go

expression: remove redundant "errors.Trace()" in "expression" package (#8609)

2018-12-07 12:20:31 +08:00

concat.go

*: use SetString() for string instead of SetBytes() (#14989)

2020-03-02 15:48:10 +08:00

count.go

expression: remove redundant "errors.Trace()" in "expression" package (#8609)

2018-12-07 12:20:31 +08:00

descriptor.go

executor: add new agg function APPROX_COUNT_DISTINCT (#17175)

2020-06-18 22:00:14 +08:00

explain.go

planner, expression: Remove the default asc order in explain result (#17074)

2020-05-14 17:38:19 +08:00

first_row.go

*: reduce the allocation caused by Datum.Copy (#15219)

2020-03-09 17:38:46 +08:00

max_min.go

*: reduce the allocation caused by Datum.Copy (#15219)

2020-03-09 17:38:46 +08:00

sum.go

remove types.Row interface (#7170)

2018-07-27 13:45:03 +08:00

util_test.go

expression: speed up unit tests under the expression package (#12887)

2019-10-23 03:56:31 -05:00

util.go

*: reduce the allocation caused by Datum.Copy (#15219)

2020-03-09 17:38:46 +08:00

window_func.go

*: let baseFuncDesc.typeInfer return error instead of panic (#10910)

2019-06-24 13:09:14 +08:00