github-mirror/BookStack
2
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-06-04 00:44:41 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed failing test and added more accessibility improvements

Browse Source 
- Updated linked images to have obvious focus styles
- Added proper role to notifications
- Made dropdown list focus styles a bit nicer.
- Updated book list chapter child slide down to be keyboard activatable.

Related to #1320
This commit is contained in:
Dan Brown
2019-08-25 17:21:25 +01:00
parent 9fbef8cd1b
commit 2dfe6c2d56
7 changed files with 19 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
resources/views/chapters/child-menu.blade.php
View File

@ -1,5 +1,5 @@
<div class="chapter-child-menu">
<button chapter-toggle type="button" aria-expanded="{{ $isOpen ? 'true' : 'false' }}" aria-label="{{ trans('common.profile_menu') }}"
<button chapter-toggle type="button" aria-expanded="{{ $isOpen ? 'true' : 'false' }}"
class="text-muted @if($isOpen) open @endif">
@icon('caret-right') @icon('page') <span>{{ trans_choice('entities.x_pages', $bookChild->pages->count()) }}</span>
</button>

4
resources/views/chapters/list-item.blade.php
View File

@ -11,7 +11,9 @@
<div class="chapter chapter-expansion">
<span class="icon text-chapter">@icon('page')</span>
<div class="content">
<div chapter-toggle class="text-muted chapter-expansion-toggle">@icon('caret-right') <span>{{ trans_choice('entities.x_pages', $chapter->pages->count()) }}</span></div>
<button type="button" chapter-toggle
aria-expanded="false"
class="text-muted chapter-expansion-toggle">@icon('caret-right') <span>{{ trans_choice('entities.x_pages', $chapter->pages->count()) }}</span></button>
<div class="inset-list">
<div class="entity-list-item-children">
@include('partials.entity-list', ['entities' => $chapter->pages])

2
resources/views/partials/custom-styles.blade.php
View File

@ -3,4 +3,4 @@
--color-primary: {{ setting('app-color') }};
--color-primary-light: {{ setting('app-color-light') }};
}
</style>
</style>

6
resources/views/partials/notifications.blade.php
View File

@ -1,11 +1,11 @@
<div notification="success" style="display: none;" data-autohide class="pos" @if(session()->has('success')) data-show @endif>
<div notification="success" style="display: none;" data-autohide class="pos" role="alert" @if(session()->has('success')) data-show @endif>
@icon('check-circle') <span>{!! nl2br(htmlentities(session()->get('success'))) !!}</span>
</div>
<div notification="warning" style="display: none;" class="warning" @if(session()->has('warning')) data-show @endif>
<div notification="warning" style="display: none;" class="warning" role="alert" @if(session()->has('warning')) data-show @endif>
@icon('info') <span>{!! nl2br(htmlentities(session()->get('warning'))) !!}</span>
</div>
<div notification="error" style="display: none;" class="neg" @if(session()->has('error')) data-show @endif>
<div notification="error" style="display: none;" class="neg" role="alert" @if(session()->has('error')) data-show @endif>
@icon('danger') <span>{!! nl2br(htmlentities(session()->get('error'))) !!}</span>
</div>