github-mirror/BookStack
2
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-06-02 23:56:56 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Updated page delete to handle inactive custom homepage correctly

Browse Source 
Fixes #1447
This commit is contained in:
Dan Brown
2019-05-27 12:40:19 +01:00
parent 2b7362fa94
commit 3ad1b42a74
2 changed files with 27 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
tests/HomepageTest.php
View File

@ -38,10 +38,14 @@ class HomepageTest extends TestCase
$name = 'My custom homepage';
$content = str_repeat('This is the body content of my custom homepage.', 20);
$customPage = $this->newPage(['name' => $name, 'html' => $content]);
$this->setSettings(['app-homepage' => $customPage->id]);
$this->setSettings([
'app-homepage' => $customPage->id,
'app-homepage-type' => 'page'
]);
$homeVisit = $this->get('/');
$homeVisit->assertSee($name);
$homeVisit->assertElementNotExists('#home-default');
$pageDeleteReq = $this->delete($customPage->getUrl());
$pageDeleteReq->assertStatus(302);
@ -54,6 +58,23 @@ class HomepageTest extends TestCase
$homeVisit->assertStatus(200);
}
public function test_custom_homepage_can_be_deleted_once_custom_homepage_no_longer_used()
{
$this->asEditor();
$name = 'My custom homepage';
$content = str_repeat('This is the body content of my custom homepage.', 20);
$customPage = $this->newPage(['name' => $name, 'html' => $content]);
$this->setSettings([
'app-homepage' => $customPage->id,
'app-homepage-type' => 'default'
]);
$pageDeleteReq = $this->delete($customPage->getUrl());
$pageDeleteReq->assertStatus(302);
$pageDeleteReq->assertSessionHas('success');
$pageDeleteReq->assertSessionMissing('error');
}
public function test_set_book_homepage()
{
$editor = $this->getEditor();