From 505d7e604ee87b3ac6d5a661b2da8c73b87d867b Mon Sep 17 00:00:00 2001 From: Dan Brown Date: Wed, 29 Sep 2021 23:53:11 +0100 Subject: [PATCH] Applied StyleCI changes --- app/Actions/ActivityService.php | 2 +- app/Auth/Permissions/PermissionService.php | 2 +- tests/AuditLogTest.php | 16 ++++++++-------- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/app/Actions/ActivityService.php b/app/Actions/ActivityService.php index f8a0825bb..bc7a6b6b7 100644 --- a/app/Actions/ActivityService.php +++ b/app/Actions/ActivityService.php @@ -11,7 +11,6 @@ use BookStack\Interfaces\Loggable; use Illuminate\Database\Eloquent\Builder; use Illuminate\Database\Eloquent\Relations\Relation; use Illuminate\Support\Facades\Log; -use Illuminate\Support\Facades\Request; class ActivityService { @@ -57,6 +56,7 @@ class ActivityService protected function newActivityForUser(string $type): Activity { $ip = request()->ip() ?? ''; + return $this->activity->newInstance()->forceFill([ 'type' => strtolower($type), 'user_id' => user()->id, diff --git a/app/Auth/Permissions/PermissionService.php b/app/Auth/Permissions/PermissionService.php index 4fcad554b..139725339 100644 --- a/app/Auth/Permissions/PermissionService.php +++ b/app/Auth/Permissions/PermissionService.php @@ -642,7 +642,7 @@ class PermissionService $query->whereExists(function ($permissionQuery) use (&$tableDetails, $morphClass) { /** @var Builder $permissionQuery */ $permissionQuery->select('id')->from('joint_permissions') - ->whereColumn('joint_permissions.entity_id', '=', $tableDetails['tableName'] . '.' . $tableDetails['entityIdColumn']) + ->whereColumn('joint_permissions.entity_id', '=', $tableDetails['tableName'] . '.' . $tableDetails['entityIdColumn']) ->where('entity_type', '=', $morphClass) ->where('action', '=', 'view') ->whereIn('role_id', $this->getCurrentUserRoles()) diff --git a/tests/AuditLogTest.php b/tests/AuditLogTest.php index 9f6576a46..8d13670ca 100644 --- a/tests/AuditLogTest.php +++ b/tests/AuditLogTest.php @@ -152,13 +152,13 @@ class AuditLogTest extends TestCase 'name' => 'Updated page', 'html' => '

Updated content

', ], [ - 'X-Forwarded-For' => '192.123.45.1' + 'X-Forwarded-For' => '192.123.45.1', ])->assertRedirect($page->refresh()->getUrl()); $this->assertDatabaseHas('activities', [ - 'type' => ActivityType::PAGE_UPDATE, - 'ip' => '192.123.45.1', - 'user_id' => $editor->id, + 'type' => ActivityType::PAGE_UPDATE, + 'ip' => '192.123.45.1', + 'user_id' => $editor->id, 'entity_id' => $page->id, ]); @@ -179,13 +179,13 @@ class AuditLogTest extends TestCase 'html' => '

Updated content

', ], [ 'X-Forwarded-For' => '192.123.45.1', - 'REMOTE_ADDR' => '192.123.45.2', + 'REMOTE_ADDR' => '192.123.45.2', ])->assertRedirect($page->refresh()->getUrl()); $this->assertDatabaseHas('activities', [ - 'type' => ActivityType::PAGE_UPDATE, - 'ip' => '127.0.0.1', - 'user_id' => $editor->id, + 'type' => ActivityType::PAGE_UPDATE, + 'ip' => '127.0.0.1', + 'user_id' => $editor->id, 'entity_id' => $page->id, ]); }