github-mirror/BookStack
2
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-06-04 17:04:32 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed incorrect API listing total when offset set

Browse Source 
Fixes #2043
This commit is contained in:
Dan Brown
2020-04-25 16:38:11 +01:00
parent 0883b0533b
commit 79a949836b
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
tests/Api/ApiListingTest.php
View File

@ -81,4 +81,20 @@ class ApiListingTest extends TestCase
}
}
public function test_total_on_results_shows_correctly()
{
$this->actingAsApiEditor();
$bookCount = Book::query()->count();
$resp = $this->get($this->endpoint . '?count=1');
$resp->assertJson(['total' => $bookCount ]);
}
public function test_total_on_results_shows_correctly_when_offset_provided()
{
$this->actingAsApiEditor();
$bookCount = Book::query()->count();
$resp = $this->get($this->endpoint . '?count=1&offset=1');
$resp->assertJson(['total' => $bookCount ]);
}
}