github-mirror/BookStack
2
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-06-04 17:04:32 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Aligned item creation wording and updated shelf-book-add logic

Browse Source
This commit is contained in:
Dan Brown
2019-04-15 20:43:25 +01:00
parent 84419005e7
commit 7f3f6e65b9
9 changed files with 55 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/Entity/BookShelfTest.php
View File

@ -48,7 +48,7 @@ class BookShelfTest extends TestCase
public function test_shelves_page_contains_create_link()
{
$resp = $this->asEditor()->get('/shelves');
$resp->assertElementContains('a', 'Create New Shelf');
$resp->assertElementContains('a', 'New Shelf');
}
public function test_shelves_create()
@ -103,7 +103,7 @@ class BookShelfTest extends TestCase
$resp->assertSee($shelf->getUrl('/edit'));
$resp->assertSee($shelf->getUrl('/permissions'));
$resp->assertSee($shelf->getUrl('/delete'));
$resp->assertElementContains('a', 'Create New Book');
$resp->assertElementContains('a', 'New Book');
$resp->assertElementContains('a', 'Edit');
$resp->assertElementContains('a', 'Permissions');
$resp->assertElementContains('a', 'Delete');
@ -164,9 +164,15 @@ class BookShelfTest extends TestCase
'name' => $testName,
'description' => 'Book in shelf description'
]);
$createBookResp->assertRedirect();
$newBook = Book::query()->orderBy('id', 'desc')->first();
$this->assertDatabaseHas('bookshelves_books', [
'bookshelf_id' => $shelf->id,
'book_id' => $newBook->id,
]);
$resp = $this->asEditor()->get($shelf->getUrl());
$resp->assertSee($testName);
}

2
tests/Permissions/RolesTest.php
View File

@ -215,7 +215,7 @@ class RolesTest extends BrowserKitTest
$this->checkAccessPermission('bookshelf-create-all', [
'/create-shelf'
], [
'/shelves' => 'Create New Shelf'
'/shelves' => 'New Shelf'
]);
$this->visit('/create-shelf')