Updated user profile image delete to delete all uploads

Also moved test and made more comprehensive

tests/ImageTest.php

@@ -184,4 +184,28 @@ class ImageTest extends TestCase
         $this->assertTrue($testImageData === $uploadedImageData, "Uploaded image file data does not match our test image as expected");
     }
 
+    public function test_user_images_deleted_on_user_deletion()
+    {
+        $editor = $this->getEditor();
+        $this->actingAs($editor);
+
+        $imageName = 'profile.png';
+        $relPath = $this->getTestImagePath('gallery', $imageName);
+        $this->deleteImage($relPath);
+
+        $file = $this->getTestImage($imageName);
+        $this->call('POST', '/images/user/upload', [], [], ['file' => $file], []);
+        $this->call('POST', '/images/user/upload', [], [], ['file' => $file], []);
+
+        $profileImages = Image::where('type', '=', 'user')->where('created_by', '=', $editor->id)->get();
+        $this->assertTrue($profileImages->count() === 2, "Found profile images does not match upload count");
+
+        $userDelete = $this->asAdmin()->delete("/settings/users/{$editor->id}");
+        $userDelete->assertStatus(302);
+        $this->assertDatabaseMissing('images', [
+            'type' => 'user',
+            'created_by' => $editor->id
+        ]);
+    }
+
 }

tests/UserProfileTest.php

@@ -115,19 +115,5 @@ class UserProfileTest extends BrowserKitTest
             ->visit('/books')
             ->pageHasElement('.featured-image-container');
     }
-    
-    public function test_user_delete() 
-    {
-        $newUser = $this->getNewBlankUser();
-        $this->actingAs($newUser);
-        $this->asAdmin()->visit('/settings/users/' . $newUser->id . '/delete')
-		->see('Delete User')
-		->press('Confirm')
-		->seePageIs('/settings/users/')
-		->see('USERS')->see('ADD NEW USER');
-        
-        $this->dontSeeInDatabase('images', [
-		'id' => $newUser->image_id
-            ]);
-    }
+
 }