github-mirror/BookStack
2
0
Fork 0
mirror of https://github.com/BookStackApp/BookStack.git synced 2025-06-03 16:23:35 +08:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Prevented saml2 autodiscovery on metadata load

Browse Source 
Fixes issue where metadata cannot be viewed if autload is active and
entityid url is not active.
For #2480
This commit is contained in:
Dan Brown
2022-10-16 09:50:08 +01:00
parent 0269f5122e
commit f0ac454be1
2 changed files with 22 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/Auth/Saml2Test.php
View File

@ -41,6 +41,20 @@ class Saml2Test extends TestCase
$req->assertSee(url('/saml2/acs'));
}
public function test_metadata_endpoint_loads_when_autoloading_with_bad_url_set()
{
config()->set([
'saml2.autoload_from_metadata' => true,
'saml2.onelogin.idp.entityId' => 'http://192.168.1.1:9292',
'saml2.onelogin.idp.singleSignOnService.url' => null,
]);
$req = $this->get('/saml2/metadata');
$req->assertOk();
$req->assertHeader('Content-Type', 'text/xml; charset=UTF-8');
$req->assertSee('md:EntityDescriptor');
}
public function test_onelogin_overrides_functions_as_expected()
{
$json = '{"sp": {"assertionConsumerService": {"url": "https://example.com/super-cats"}}, "contactPerson": {"technical": {"givenName": "Barry Scott", "emailAddress": "barry@example.com"}}}';