diff --git a/modules/logging/filewriter.go b/modules/logging/filewriter.go index eed9c10f4..c14cf4607 100644 --- a/modules/logging/filewriter.go +++ b/modules/logging/filewriter.go @@ -172,14 +172,14 @@ func (fw FileWriter) OpenWriter() (io.WriteCloser, error) { if err != nil { return nil, err } + info, err := f_tmp.Stat() f_tmp.Close() - // ensure already existing files have the right mode, + // Ensure already existing files have the right mode, // since OpenFile will not set the mode in such case. - // only chmod if the mode needs to be changed, however - info, err := f_tmp.Stat() if err == nil { desiredMode := os.FileMode(fw.Mode) + // only chmod if the mode needs to be changed if info.Mode()&os.ModePerm != desiredMode&os.ModePerm { if err = os.Chmod(fw.Filename, desiredMode); err != nil { return nil, err