github-mirror/caddy
2
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2025-05-30 15:58:10 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Miscellaneous cleanups / comments

Browse Source
This commit is contained in:
Matthew Holt
2019-10-10 15:38:30 -06:00
parent 5300949e0d
commit 9c0bf311f9
8 changed files with 56 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
modules/caddyhttp/reverseproxy/fastcgi/fastcgi.go
View File

@ -110,6 +110,7 @@ func (t Transport) RoundTrip(r *http.Request) (*http.Response, error) {
fcgiBackend, err := DialContext(ctx, network, address)
if err != nil {
// TODO: wrap in a special error type if the dial failed, so retries can happen if enabled
return nil, fmt.Errorf("dialing backend: %v", err)
}
// fcgiBackend gets closed when response body is closed (see clientCloser)

2
modules/caddyhttp/reverseproxy/reverseproxy.go
View File

@ -243,6 +243,8 @@ func (h *Handler) Cleanup() error {
close(h.HealthChecks.Active.stopChan)
}
// TODO: Close keepalive connections on reload? https://github.com/caddyserver/caddy/pull/2507/files#diff-70219fd88fe3f36834f474ce6537ed26R762
// remove hosts from our config from the pool
for _, upstream := range h.Upstreams {
hosts.Delete(upstream.dialInfo.String())