core: Retry dynamic config load if error or no-op (#4603)

Also fix ineffectual assignment (unrelated)
This commit is contained in:
Matthew Holt
2022-03-03 10:57:55 -07:00
parent f5e104944e
commit ceef70dbc5
2 changed files with 28 additions and 16 deletions

View File

@ -262,7 +262,7 @@ func (admin *AdminConfig) newAdminHandler(addr NetworkAddress, remote bool) admi
// provisionAdminRouters provisions all the router modules
// in the admin.api namespace that need provisioning.
func (admin AdminConfig) provisionAdminRouters(ctx Context) error {
func (admin *AdminConfig) provisionAdminRouters(ctx Context) error {
for _, router := range admin.routers {
provisioner, ok := router.(Provisioner)
if !ok {
@ -277,6 +277,7 @@ func (admin AdminConfig) provisionAdminRouters(ctx Context) error {
// We no longer need the routers once provisioned, allow for GC
admin.routers = nil
return nil
}