github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 03:51:07 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Show large image placeholder for image onebox (#21237)

Browse Source 
Large or broken images are removed from oneboxes, but sometimes images
were removed when they were oneboxed too. The reason is that images can
be oneboxed by the AllowlistedGenericOnebox or ImageOnebox and only
AllowlistedGenericOnebox was handled correctly.
This commit is contained in:
Bianca Nenciu
2023-04-26 19:05:22 +02:00
committed by GitHub
parent a1b35601fc
commit 024b8b2640
2 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/cooked_post_processor.rb
View File

@ -385,6 +385,8 @@ class CookedPostProcessor
end
def process_hotlinked_image(img)
onebox = img.ancestors(".onebox, .onebox-body").first
@hotlinked_map ||= @post.post_hotlinked_media.preload(:upload).map { |r| [r.url, r] }.to_h
normalized_src =
PostHotlinkedMedia.normalize_src(img["src"] || img[PrettyText::BLOCKED_HOTLINKED_SRC_ATTR])
@ -393,7 +395,7 @@ class CookedPostProcessor
still_an_image = true
if info&.too_large?
if img.ancestors(".onebox, .onebox-body").blank?
if !onebox || onebox.element_children.size == 1
add_large_image_placeholder!(img)
else
img.remove
@ -401,7 +403,7 @@ class CookedPostProcessor
still_an_image = false
elsif info&.download_failed?
if img.ancestors(".onebox, .onebox-body").blank?
if !onebox || onebox.element_children.size == 1
add_broken_image_placeholder!(img)
else
img.remove