github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 16:48:03 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: reduce logging when no external id is specified

Browse Source 
Previously we were returning an unknown sso error and logging a message
when external id was blank. This noise is not needed.
This commit is contained in:
Sam Saffron
2020-04-08 12:42:28 +10:00
parent 236833ed5d
commit 0375a5ac0b
4 changed files with 35 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
spec/requests/session_controller_spec.rb
View File

@ -563,9 +563,13 @@ RSpec.describe SessionController do
sso.external_id = ' '
sso.username = 'sam'
get "/session/sso_login", params: Rack::Utils.parse_query(sso.payload), headers: headers
messages = track_log_messages(level: Logger::WARN) do
get "/session/sso_login", params: Rack::Utils.parse_query(sso.payload), headers: headers
end
expect(messages.length).to eq(0)
expect(response.status).to eq(500)
expect(response.body).to include(I18n.t('sso.blank_id_error'))
end
it 'can handle invalid sso external ids due to banned word' do
@ -1165,12 +1169,9 @@ RSpec.describe SessionController do
SiteSetting.enable_local_logins_via_email = false
end
it 'doesnt matter, logs in correctly' do
events = DiscourseEvent.track_events do
post "/session.json", params: {
login: user.username, password: 'myawesomepassword'
}
end
post "/session.json", params: {
login: user.username, password: 'myawesomepassword'
}
expect(response.status).to eq(200)
end
end