github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-24 02:01:15 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: select-kit 2 (#7998)

Browse Source 
This new iteration of select-kit focuses on following best principales and disallowing mutations inside select-kit components. A best effort has been made to avoid breaking changes, however if you content was a flat array, eg: ["foo", "bar"] You will need to set valueProperty=null and nameProperty=null on the component.

Also almost every component should have an `onChange` handler now to decide what to do with the updated data. **select-kit will not mutate your data by itself anymore**
This commit is contained in:
Joffrey JAFFEUX
2020-02-03 14:22:14 +01:00
committed by GitHub
parent 0e2cbee339
commit 0431942f3d
278 changed files with 7566 additions and 6957 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
plugins/poll/test/javascripts/acceptance/poll-builder-enabled-test.js.es6
View File

@ -9,54 +9,48 @@ acceptance("Poll Builder - polls are enabled", {
poll_enabled: true,
poll_minimum_trust_level_to_create: 1
},
beforeEach: function() {
beforeEach() {
clearPopupMenuOptionsCallback();
}
});
test("regular user - sufficient trust level", assert => {
test("regular user - sufficient trust level", async assert => {
updateCurrentUser({ moderator: false, admin: false, trust_level: 1 });
displayPollBuilderButton();
await displayPollBuilderButton();
andThen(() => {
assert.ok(
exists(".select-kit-row[title='Build Poll']"),
"it shows the builder button"
);
});
assert.ok(
exists(".select-kit-row[title='Build Poll']"),
"it shows the builder button"
);
});
test("regular user - insufficient trust level", assert => {
test("regular user - insufficient trust level", async assert => {
updateCurrentUser({ moderator: false, admin: false, trust_level: 0 });
displayPollBuilderButton();
await displayPollBuilderButton();
andThen(() => {
assert.ok(
!exists(".select-kit-row[title='Build Poll']"),
"it hides the builder button"
);
});
assert.ok(
!exists(".select-kit-row[title='Build Poll']"),
"it hides the builder button"
);
});
test("staff - with insufficient trust level", assert => {
test("staff - with insufficient trust level", async assert => {
updateCurrentUser({ moderator: true, trust_level: 0 });
displayPollBuilderButton();
await displayPollBuilderButton();
andThen(() => {
assert.ok(
exists(".select-kit-row[title='Build Poll']"),
"it shows the builder button"
);
});
assert.ok(
exists(".select-kit-row[title='Build Poll']"),
"it shows the builder button"
);
});
test("poll preview", async assert => {
displayPollBuilderButton();
await displayPollBuilderButton();
const popupMenu = selectKit(".toolbar-popup-menu-options");
await popupMenu.expand();
await popupMenu.selectRowByValue("showPollBuilder");
await fillIn(".poll-textarea textarea", "First option\nSecond option");