github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-29 07:14:37 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Show mobile view as default for nexus 7 tablet

Browse Source
This commit is contained in:
Neil Lalonde 2013-09-23 17:13:29 -07:00
parent 500a24ebf9
commit 07d08b81c7
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/helpers/application_helper.rb
View File

@ -119,6 +119,6 @@ module ApplicationHelper
def mobile_device? def mobile_device?
# TODO: this is dumb. user agent matching is a doomed approach. a better solution is coming. # TODO: this is dumb. user agent matching is a doomed approach. a better solution is coming.
request.user_agent =~ /Mobile|webOS/ and !(request.user_agent =~ /iPad/) request.user_agent =~ /Mobile|webOS|Nexus 7/ and !(request.user_agent =~ /iPad/)
end end
end end

9
spec/helpers/application_helper_spec.rb
View File

@ -34,10 +34,15 @@ describe ApplicationHelper do
helper.mobile_view?.should be_false helper.mobile_view?.should be_false
end end
it "is false for Android tablet" do it "is false for Nexus 10 tablet" do
controller.request.stubs(:user_agent).returns("Mozilla/5.0 (Linux; Android 4.1.2; Nexus 7 Build/JZ054K) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.166 Safari/535.19") controller.request.stubs(:user_agent).returns("Mozilla/5.0 (Linux; Android 4.2.1; Nexus 10 Build/JOP40D) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.166 Safari/535.19")
helper.mobile_view?.should be_false helper.mobile_view?.should be_false
end end
it "is true for Nexus 7 tablet" do
controller.request.stubs(:user_agent).returns("Mozilla/5.0 (Linux; Android 4.1.2; Nexus 7 Build/JZ054K) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.166 Safari/535.19")
helper.mobile_view?.should be_true
end
end end
end end