FIX: email replies to closed topic should not be accepted

spec/components/email/receiver_spec.rb

@@ -222,6 +222,37 @@ Pleasure to have you here!
 
   end
 
+  describe "posting reply to a closed topic" do
+    let(:reply_key) { raise "Override this in a lower describe block" }
+    let(:email_raw) { raise "Override this in a lower describe block" }
+    let(:receiver) { Email::Receiver.new(email_raw) }
+    let(:topic) { Fabricate(:topic, closed: true) }
+    let(:post) { Fabricate(:post, topic: topic, post_number: 1) }
+    let(:replying_user_email) { 'jake@adventuretime.ooo' }
+    let(:replying_user) { Fabricate(:user, email: replying_user_email, trust_level: 2) }
+    let(:email_log) { EmailLog.new(reply_key: reply_key,
+                                   post: post,
+                                   post_id: post.id,
+                                   topic_id: topic.id,
+                                   email_type: 'user_posted',
+                                   user: replying_user,
+                                   user_id: replying_user.id,
+                                   to_address: replying_user_email
+    ) }
+
+    before do
+      email_log.save
+    end
+
+    describe "should not create post" do
+      let!(:reply_key) { '59d8df8370b7e95c5a49fbf86aeb2c93' }
+      let!(:email_raw) { fixture_file("emails/valid_reply.eml") }
+      it "raises a TopicClosedError" do
+        expect { receiver.process }.to raise_error(Email::Receiver::TopicClosedError)
+      end
+    end
+  end
+
   describe "posting a new topic" do
     let(:category_destination) { raise "Override this in a lower describe block" }
     let(:email_raw) { raise "Override this in a lower describe block" }

spec/jobs/poll_mailbox_spec.rb

@@ -207,6 +207,31 @@ describe Jobs::PollMailbox do
       end
     end
 
+    describe "when topic is closed" do
+      let(:email) { MockPop3EmailObject.new fixture_file('emails/valid_reply.eml')}
+      let(:topic) { Fabricate(:topic, closed: true) }
+      let(:first_post) { Fabricate(:post, topic: topic, post_number: 1)}
+
+      before do
+        first_post.save
+        EmailLog.create(to_address: 'jake@email.example.com',
+                        email_type: 'user_posted',
+                        reply_key: '59d8df8370b7e95c5a49fbf86aeb2c93',
+                        user: user,
+                        post: first_post,
+                        topic: topic)
+      end
+
+      describe "should not create post" do
+        it "raises a TopicClosedError" do
+          expect_exception Email::Receiver::TopicClosedError
+
+          poller.handle_mail(email)
+          email.should be_deleted
+        end
+      end
+    end
+
     describe "in failure conditions" do
 
       it "a valid reply without an email log raises an EmailLogNotFound error" do
@@ -233,7 +258,6 @@ describe Jobs::PollMailbox do
         email.should be_deleted
       end
 
-
     end
   end