FEATURE: Add plugin API to register About stat group (#17442)

This commit introduces a new plugin API to register
a group of stats that will be included in about.json
and also conditionally in the site about UI at /about.

The usage is like this:

```ruby
register_about_stat_group("chat_messages", show_in_ui: true) do
  {
    last_day: 1,
    "7_days" => 10,
    "30_days" => 100,
    count: 1000,
    previous_30_days: 120
  }
end
```

In reality the stats will be generated any way the implementer
chooses within the plugin. The `last_day`, `7_days`, `30_days,` and `count`
keys must be present but apart from that additional stats may be added.
Only those core 4 stat keys will be shown in the UI, but everything will be shown
in about.json.

The stat group name is used to prefix the stats in about.json like so:

```json
"chat_messages_last_day": 2322,
"chat_messages_7_days": 2322,
"chat_messages_30_days": 2322,
"chat_messages_count": 2322,
```

The `show_in_ui` option (default false) is used to determine whether the
group of stats is shown on the site About page in the Site Statistics
table. Some stats may be needed purely for reporting purposes and thus
do not need to be shown in the UI to admins/users. An extension to the Site
serializer, `displayed_about_plugin_stat_groups`, has been added so this
can be inspected on the client-side.
This commit is contained in:
Martin Brennan
2022-07-15 13:16:00 +10:00
committed by GitHub
parent 8dad778fcc
commit 098ab29d41
12 changed files with 249 additions and 11 deletions

View File

@ -6,6 +6,72 @@ describe About do
include_examples 'stats cacheable'
end
describe "#stats" do
after do
About.clear_plugin_stat_groups
end
it "adds plugin stats to the output" do
stats = { last_day: 1, "7_days" => 10, "30_days" => 100, count: 1000 }
About.add_plugin_stat_group("some_group", show_in_ui: true) do
stats
end
expect(described_class.new.stats.with_indifferent_access).to match(
hash_including(
some_group_last_day: 1,
some_group_7_days: 10,
some_group_30_days: 100,
some_group_count: 1000,
)
)
end
it "does not add plugin stats to the output if they are missing one of the required keys" do
stats = { "7_days" => 10, "30_days" => 100, count: 1000 }
About.add_plugin_stat_group("some_group", show_in_ui: true) do
stats
end
expect(described_class.new.stats).not_to match(
hash_including(
some_group_last_day: 1,
some_group_7_days: 10,
some_group_30_days: 100,
some_group_count: 1000,
)
)
end
it "does not error if any of the plugin stat blocks throw an error and still adds the non-errored stats to output" do
stats = { last_day: 1, "7_days" => 10, "30_days" => 100, count: 1000 }
About.add_plugin_stat_group("some_group", show_in_ui: true) do
stats
end
About.add_plugin_stat_group("other_group", show_in_ui: true) do
raise StandardError
end
expect(described_class.new.stats.with_indifferent_access).to match(
hash_including(
some_group_last_day: 1,
some_group_7_days: 10,
some_group_30_days: 100,
some_group_count: 1000,
)
)
expect { described_class.new.stats.with_indifferent_access }.not_to raise_error
end
it "does not allow duplicate displayed stat groups" do
stats = { last_day: 1, "7_days" => 10, "30_days" => 100, count: 1000 }
About.add_plugin_stat_group("some_group", show_in_ui: true) do
stats
end
About.add_plugin_stat_group("some_group", show_in_ui: true) do
stats
end
expect(described_class.displayed_plugin_stat_groups).to eq(["some_group"])
end
end
describe "#category_moderators" do
let(:user) { Fabricate(:user) }
let(:public_cat_moderator) { Fabricate(:user, last_seen_at: 1.month.ago) }