github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 17:58:16 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Pass in site guardian for Plugin::Instance.register_site_categories_callback (#19430)

Browse Source 
The guardian is useful for plugins to determine if the callback should
do anything. A common use case is to not do anything in the callback if
the user is anonymous.
This commit is contained in:
Alan Guo Xiang Tan
2022-12-13 07:49:13 +08:00
committed by GitHub
parent 3ee4b59c64
commit 0abd772098
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/site.rb
View File

@ -134,7 +134,7 @@ class Site
categories.reject! { |c| c[:parent_category_id] && !by_id[c[:parent_category_id]] } categories.reject! { |c| c[:parent_category_id] && !by_id[c[:parent_category_id]] }
self.class.categories_callbacks.each do |callback| self.class.categories_callbacks.each do |callback|
callback.call(categories) callback.call(categories, @guardian)
end end
categories categories

8
spec/lib/plugin/instance_spec.rb
View File

@ -649,13 +649,17 @@ RSpec.describe Plugin::Instance do
it 'adds a callback to the Site#categories' do it 'adds a callback to the Site#categories' do
instance = Plugin::Instance.new instance = Plugin::Instance.new
instance.register_site_categories_callback do |categories| site_guardian = Guardian.new
instance.register_site_categories_callback do |categories, guardian|
categories.each do |category| categories.each do |category|
category[:test_field] = "test" category[:test_field] = "test"
end end
expect(guardian).to eq(site_guardian)
end end
site = Site.new(Guardian.new) site = Site.new(site_guardian)
expect(site.categories.first[:test_field]).to eq("test") expect(site.categories.first[:test_field]).to eq("test")
ensure ensure