github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-24 03:36:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Deprecate success and error in Discourse.ajax

Browse Source
This commit is contained in:
Robin Ward
2013-05-07 11:15:28 -04:00
parent 6cbcd6e4a6
commit 0b4fc5d81c
17 changed files with 61 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
app/assets/javascripts/discourse.js
View File

@ -194,7 +194,30 @@ Discourse = Ember.Application.createWithMixins({
@method ajax
**/
ajax: function() {
return $.ajax.apply(this, arguments);
var url, args;
if (arguments.length === 1) {
if (typeof arguments[0] === "string") {
url = arguments[0];
args = {};
} else {
args = arguments[0];
url = args.url;
delete args.url;
}
} else if (arguments.length === 2) {
url = arguments[0];
args = arguments[1];
}
if (args.success) {
console.log("DEPRECATION: Discourse.ajax should use promises, received 'success' callback");
}
if (args.error) {
console.log("DEPRECATION: Discourse.ajax should use promises, received 'error' callback");
}
return $.ajax(url, args);
},
/**