github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 16:41:17 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Correct deprecated theme settings in handlebars templates

Browse Source 
Was overriding the incorrect `themeSetting.blah` syntax, instead of `themeSettings.blah`
This commit is contained in:
David Taylor
2019-01-18 15:39:28 +00:00
parent b9b5527c63
commit 0b6be2cebc
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/lib/theme_javascript_compiler_spec.rb
View File

@ -55,11 +55,11 @@ describe ThemeJavascriptCompiler do
end
it 'works with the old settings syntax' do
expect(render("{{themeSetting.setting_key}}")).
expect(render("{{themeSettings.setting_key}}")).
to eq('setting(22:setting_key)')
# Works when used inside other statements
expect(render("{{dummy-helper themeSetting.setting_key}}")).
expect(render("{{dummy-helper themeSettings.setting_key}}")).
to eq('dummy(setting(22:setting_key))')
end
end
@ -90,11 +90,11 @@ describe ThemeJavascriptCompiler do
end
it 'works with the old settings syntax' do
expect(statement("{{themeSetting.setting_key}}")).
expect(statement("{{themeSettings.setting_key}}")).
to eq([[1, [27, "theme-setting", [22, "setting_key"], [["deprecated"], [true]]], false]])
# Works when used inside other statements
expect(statement("{{dummy-helper themeSetting.setting_key}}")).
expect(statement("{{dummy-helper themeSettings.setting_key}}")).
to eq([[1, [27, "dummy-helper", [[27, "theme-setting", [22, "setting_key"], [["deprecated"], [true]]]], nil], false]])
end
end