DEV: Improve code comment about when ignored columns can be removed (#26894)

Ignored columns can only be dropped when its associated post-deploy
migration has been promoted to a regular migration. This is so because
Discourse doesn't rely on a schema file system to setup a brand new
database and thus the column information will be loaded by the
application first before the post-deploy migration runs.
This commit is contained in:
Alan Guo Xiang Tan
2024-05-07 11:06:31 +08:00
committed by GitHub
parent 2347ff7074
commit 0b947b6aab
15 changed files with 19 additions and 27 deletions

View File

@ -2,7 +2,7 @@
class UserApiKey < ActiveRecord::Base
self.ignored_columns = [
"scopes", # TODO(2020-12-18): remove
"scopes", # TODO: Remove when 20240212034010_drop_deprecated_columns has been promoted to pre-deploy
]
REVOKE_MATCHER = RouteMatcher.new(actions: "user_api_keys#revoke", methods: :post, params: [:id])