UX: Do not delete narrative bot PM when skipping user tips (#28265)

Should fix https://meta.discourse.org/t/skip-tips-option-in-user-tip-should-not-delete-welcome-message/303420

Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
This commit is contained in:
Penar Musaraj
2024-08-08 12:12:01 -04:00
committed by GitHub
parent c197daa04c
commit 0d289a5690
3 changed files with 32 additions and 38 deletions

View File

@ -111,16 +111,6 @@ RSpec.describe User do
SiteSetting.default_other_skip_new_user_tips = true
expect { user }.to_not change { Post.count }
end
it "should delete the existing PM" do
user.user_option.skip_new_user_tips = true
expect { user.user_option.save! }.to change { Topic.count }.by(-1).and not_change {
UserHistory.count
}.and change { user.unread_high_priority_notifications }.by(-1).and change {
user.notifications.count
}.by(-1)
end
end
context "when user is anonymous?" do