FIX: Restore trust level when leaving group (#17954)

If a user was granted a trust level, joined a group that granted a trust
level and left the group, the trust level was reset. This commit tries
to restore the last known trust level before joining the group by
looking into staff logs.

This commit also migrates old :change_trust_level user history records
to use previous_value and new_value fields.
This commit is contained in:
Bianca Nenciu
2022-08-29 13:00:48 +03:00
committed by GitHub
parent c4bb15441d
commit 0d8ecab362
7 changed files with 90 additions and 44 deletions

View File

@ -237,5 +237,20 @@ RSpec.describe GroupUser do
expect(user.primary_group_id).to be_nil
expect(user.flair_group_id).to be_nil
end
it "restores previous trust level" do
user = Fabricate(:user)
expect(user.trust_level).to eq(1)
user.change_trust_level!(2, log_action_for: Discourse.system_user)
user.change_trust_level!(3, log_action_for: Discourse.system_user)
group.update!(grant_trust_level: 4)
group_user = Fabricate(:group_user, group: group, user: user)
expect(user.reload.trust_level).to eq(4)
group_user.destroy!
expect(user.reload.trust_level).to eq(3)
end
end
end