mirror of
https://github.com/discourse/discourse.git
synced 2025-05-31 04:18:00 +08:00
DEV: Update the rubocop-discourse gem
This enables cops related to RSpec `subject`. See https://github.com/discourse/rubocop-discourse/pull/32
This commit is contained in:

committed by
Loïc Guitaut

parent
8e1d049e6b
commit
0f4beab0fb
@ -53,6 +53,16 @@ RSpec.describe Onebox::Engine::GoogleMapsOnebox do
|
||||
}
|
||||
|
||||
# Register URL redirects
|
||||
# Prevent sleep from wasting our time when we test with strange redirects
|
||||
subject(:onebox) do
|
||||
described_class
|
||||
.send(:allocate)
|
||||
.tap do |obj|
|
||||
obj.stubs(:sleep)
|
||||
obj.send(:initialize, link)
|
||||
end
|
||||
end
|
||||
|
||||
before do
|
||||
URLS.values.each do |t|
|
||||
status, location = *t[:redirect]
|
||||
@ -62,27 +72,17 @@ RSpec.describe Onebox::Engine::GoogleMapsOnebox do
|
||||
end
|
||||
end
|
||||
|
||||
# Prevent sleep from wasting our time when we test with strange redirects
|
||||
subject do
|
||||
described_class
|
||||
.send(:allocate)
|
||||
.tap do |obj|
|
||||
obj.stubs(:sleep)
|
||||
obj.send(:initialize, link)
|
||||
end
|
||||
end
|
||||
|
||||
let(:data) { Onebox::Helpers.symbolize_keys(subject.send(:data)) }
|
||||
let(:data) { Onebox::Helpers.symbolize_keys(onebox.send(:data)) }
|
||||
let(:link) { |example| URLS[example.metadata[:urltype] || :short][:test] }
|
||||
|
||||
include_context "an engine", urltype: :short
|
||||
|
||||
URLS.each do |kind, t|
|
||||
it "processes #{kind.to_s} url correctly", urltype: kind do
|
||||
expect(subject.url).to eq t[:expect]
|
||||
expect(subject.streetview?).to t[:streetview] ? be_truthy : be_falsey
|
||||
expect(subject.to_html).to include("<iframe")
|
||||
expect(subject.placeholder_html).to include("placeholder-icon map")
|
||||
expect(onebox.url).to eq t[:expect]
|
||||
expect(onebox.streetview?).to t[:streetview] ? be_truthy : be_falsey
|
||||
expect(onebox.to_html).to include("<iframe")
|
||||
expect(onebox.placeholder_html).to include("placeholder-icon map")
|
||||
end
|
||||
end
|
||||
end
|
||||
|
Reference in New Issue
Block a user