mirror of
https://github.com/discourse/discourse.git
synced 2025-05-22 07:53:49 +08:00
SECURITY: Safely decompress files. (#8124)
* FEATURE: Adds an extra protection layer when decompressing files. * Rename exporter/importer to zip importer. Update old locale * Added a new composite class to decompress a file with multiple strategies * Set max file size inside a site setting * Ensure that file is deleted after compression * Sanitize path and files before compressing/decompressing
This commit is contained in:
57
lib/compression/gzip.rb
Normal file
57
lib/compression/gzip.rb
Normal file
@ -0,0 +1,57 @@
|
||||
# frozen_string_literal: true
|
||||
|
||||
module Compression
|
||||
class Gzip < Strategy
|
||||
def extension
|
||||
'.gz'
|
||||
end
|
||||
|
||||
def compress(path, target_name)
|
||||
gzip_target = sanitize_path("#{path}/#{target_name}")
|
||||
Discourse::Utils.execute_command('gzip', '-5', gzip_target, failure_message: "Failed to gzip file.")
|
||||
|
||||
"#{gzip_target}.gz"
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
def entries_of(compressed_file)
|
||||
[compressed_file]
|
||||
end
|
||||
|
||||
def is_file?(_)
|
||||
true
|
||||
end
|
||||
|
||||
def extract_folder(_entry, _entry_path); end
|
||||
|
||||
def get_compressed_file_stream(compressed_file_path)
|
||||
gzip = Zlib::GzipReader.open(compressed_file_path)
|
||||
yield(gzip)
|
||||
end
|
||||
|
||||
def build_entry_path(_compressed_file, dest_path, compressed_file_path, entry, _allow_non_root_folder)
|
||||
compressed_file_path.gsub(extension, '')
|
||||
end
|
||||
|
||||
def extract_file(entry, entry_path, available_size)
|
||||
remaining_size = available_size
|
||||
|
||||
if ::File.exist?(entry_path)
|
||||
raise ::Zip::DestinationFileExistsError,
|
||||
"Destination '#{entry_path}' already exists"
|
||||
end # Change this later.
|
||||
|
||||
::File.open(entry_path, 'wb') do |os|
|
||||
buf = ''.dup
|
||||
while (buf = entry.read(chunk_size))
|
||||
remaining_size -= chunk_size
|
||||
raise ExtractFailed if remaining_size.negative?
|
||||
os << buf
|
||||
end
|
||||
end
|
||||
|
||||
remaining_size
|
||||
end
|
||||
end
|
||||
end
|
Reference in New Issue
Block a user