github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-26 08:11:50 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Remove use of stubs in tests.

Browse Source
This commit is contained in:
Guo Xiang Tan
2017-03-01 10:53:03 +08:00
parent 76dd6933d2
commit 107d6783a9
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
spec/controllers/omniauth_callbacks_controller_spec.rb
View File

@ -4,20 +4,21 @@ describe Users::OmniauthCallbacksController do
context ".find_authenticator" do context ".find_authenticator" do
it "fails if a provider is disabled" do it "fails if a provider is disabled" do
SiteSetting.stubs("enable_twitter_logins?").returns(false) SiteSetting.enable_twitter_logins = false
expect(lambda {
expect {
Users::OmniauthCallbacksController.find_authenticator("twitter") Users::OmniauthCallbacksController.find_authenticator("twitter")
}).to raise_error(Discourse::InvalidAccess) }.to raise_error(Discourse::InvalidAccess)
end end
it "fails for unknown" do it "fails for unknown" do
expect(lambda { expect {
Users::OmniauthCallbacksController.find_authenticator("twitter1") Users::OmniauthCallbacksController.find_authenticator("twitter1")
}).to raise_error(Discourse::InvalidAccess) }.to raise_error(Discourse::InvalidAccess)
end end
it "finds an authenticator when enabled" do it "finds an authenticator when enabled" do
SiteSetting.stubs("enable_twitter_logins?").returns(true) SiteSetting.enable_twitter_logins = true
expect(Users::OmniauthCallbacksController.find_authenticator("twitter")).not_to eq(nil) expect(Users::OmniauthCallbacksController.find_authenticator("twitter")).not_to eq(nil)
end end
end end