From 10caceec42f529c8797e6e5010ec2e319cb272c0 Mon Sep 17 00:00:00 2001 From: Penar Musaraj Date: Mon, 13 Dec 2021 21:03:31 -0500 Subject: [PATCH] DEV: Prefers reads helper over alias (#15282) --- .../javascripts/discourse/app/components/popup-input-tip.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/discourse/app/components/popup-input-tip.js b/app/assets/javascripts/discourse/app/components/popup-input-tip.js index 7b1c5bc6135..0ee73dbdc64 100644 --- a/app/assets/javascripts/discourse/app/components/popup-input-tip.js +++ b/app/assets/javascripts/discourse/app/components/popup-input-tip.js @@ -1,4 +1,4 @@ -import { alias, not, or } from "@ember/object/computed"; +import { not, or, reads } from "@ember/object/computed"; import discourseComputed from "discourse-common/utils/decorators"; import Component from "@ember/component"; import { getOwner } from "discourse-common/lib/get-owner"; @@ -9,7 +9,7 @@ export default Component.extend({ rerenderTriggers: ["validation.reason"], tipReason: null, lastShownAt: or("shownAt", "validation.lastShownAt"), - bad: alias("validation.failed"), + bad: reads("validation.failed"), good: not("bad"), @discourseComputed("bad")