github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 19:11:14 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Ensure we dispose of MiniRacer::Context before forking daemons (#28361)

Browse Source 
This commit updates `Demon::Base#start` to call `Discourse.before_fork`
before forking. According to the docs in `mini_racer`, we need to
"Dispose manually of all MiniRacer::Context objects prior to forking".

This commit is motivated by a segmentation fault which we are seeing in
production when killing a daemon process. Backtrace of the core dump
includes traces of `mini_racer` so we think this is the cause. Note that
we are not 100% sure if this will fix the issue.
This commit is contained in:
Alan Guo Xiang Tan
2024-08-14 12:45:34 +08:00
committed by GitHub
parent e82e255531
commit 10ff0ee0cc
3 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/discourse.rb
View File

@ -896,6 +896,20 @@ module Discourse
"/site/read-only"
end
# all forking servers must call this
# before forking, otherwise the forked process might
# be in a bad state
def self.before_fork
# V8 does not support forking, make sure all contexts are disposed
ObjectSpace.each_object(MiniRacer::Context) { |c| c.dispose }
# get rid of rubbish so we don't share it
# longer term we will use compact! here
GC.start
GC.start
GC.start
end
# all forking servers must call this
# after fork, otherwise Discourse will be
# in a bad state