refactor Topic

* move finding by username/email to User
* make SiteSetting return a range of possible post title lengths
* remove unnecessary conditions
This commit is contained in:
Gosha Arinich
2013-02-26 19:27:59 +03:00
parent 1221c393a3
commit 12d664a610
5 changed files with 25 additions and 15 deletions

View File

@ -3,10 +3,8 @@ class Admin::ImpersonateController < Admin::AdminController
def create
requires_parameters(:username_or_email)
user = User.where(['username_lower = lower(?) or lower(email) = lower(?) or lower(name) = lower(?)',
params[:username_or_email],
params[:username_or_email],
params[:username_or_email]]).first
user = User.find_by_username_or_email(params[:username_or_email]).first
raise Discourse::NotFound if user.blank?
guardian.ensure_can_impersonate!(user)