github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-04 09:34:41 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: do not show welcome CTA banner if the welcome topic is deleted (#18528)

Browse Source
This commit is contained in:
Arpit Jalan
2022-10-10 16:53:19 +05:30
committed by GitHub
parent b2a14eeb16
commit 140200ae83
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spec/models/site_spec.rb
View File

@ -232,6 +232,18 @@ RSpec.describe Site do
expect(Site.show_welcome_topic_banner?(Guardian.new(admin))).to eq(false)
expect(Discourse.cache.read(Site.welcome_topic_banner_cache_key(admin.id))).to eq(false)
end
it "returns false when welcome topic has been deleted" do
admin = Fabricate(:admin)
UserAuthToken.generate!(user_id: admin.id)
topic = Fabricate(:topic, deleted_at: 1.minute.ago)
first_post = Fabricate(:post, topic: topic, created_at: 25.days.ago)
SiteSetting.welcome_topic_id = topic.id
expect(Site.show_welcome_topic_banner?(Guardian.new(admin))).to eq(false)
expect(Discourse.cache.read(Site.welcome_topic_banner_cache_key(admin.id))).to eq(false)
end
end
end