github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 07:53:49 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Prefer public_send over send.

Browse Source
This commit is contained in:
Guo Xiang Tan
2019-05-07 09:27:05 +08:00
parent 9be70a22cd
commit 152238b4cf
74 changed files with 216 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/discourse-narrative-bot/lib/discourse_narrative_bot/base.rb
View File

@ -48,7 +48,13 @@ module DiscourseNarrativeBot
begin
old_data = @data.dup
new_post = (@skip && @state != :end) ? skip_tutorial(next_state) : self.send(action)
new_post =
if (@skip && @state != :end)
skip_tutorial(next_state)
else
self.public_send(action)
end
if new_post
old_state = old_data[:state]

5
plugins/discourse-narrative-bot/lib/discourse_narrative_bot/new_user_narrative.rb
View File

@ -532,7 +532,10 @@ module DiscourseNarrativeBot
end
def url_helpers(url, opts = {})
Rails.application.routes.url_helpers.send(url, opts.merge(host: Discourse.base_url))
Rails.application.routes.url_helpers.public_send(
url,
opts.merge(host: Discourse.base_url)
)
end
end
end