github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 21:41:03 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix category-row regressions

Browse Source
This commit is contained in:
Joffrey JAFFEUX
2018-03-27 14:11:05 +02:00
committed by GitHub
parent ff9d7a9bfb
commit 15aa712227
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/select-kit/components/category-row.js.es6
View File

@ -82,6 +82,8 @@ export default SelectKitRowComponent.extend({
@computed("category.description") @computed("category.description")
description(description) { description(description) {
return `${description.substr(0, 200)}${description.length > 200 ? '…' : ''}`; if (description) {
return `${description.substr(0, 200)}${description.length > 200 ? '…' : ''}`;
}
} }
}); });

4
test/javascripts/components/category-chooser-test.js.es6
View File

@ -35,9 +35,9 @@ componentTest('with scopedCategoryId', {
this.get('subject').expand(); this.get('subject').expand();
andThen(() => { andThen(() => {
assert.equal(this.get('subject').rowByIndex(0).title(), 'feature'); assert.equal(this.get('subject').rowByIndex(0).title(), 'Discussion about features or potential features of Discourse: how they work, why they work, etc.');
assert.equal(this.get('subject').rowByIndex(0).value(), 2); assert.equal(this.get('subject').rowByIndex(0).value(), 2);
assert.equal(this.get('subject').rowByIndex(1).title(), 'spec'); assert.equal(this.get('subject').rowByIndex(1).title(), 'My idea here is to have mini specs for features we would like built but have no bandwidth to build');
assert.equal(this.get('subject').rowByIndex(1).value(), 26); assert.equal(this.get('subject').rowByIndex(1).value(), 26);
assert.equal(this.get('subject').rows().length, 2); assert.equal(this.get('subject').rows().length, 2);
}); });