github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 16:34:31 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FEATURE: move back to the forum link above the filter (#26070)

Browse Source 
Before, the `back to forum` link was part of experimental admin navigation. It means that the link could be filtered out.

Because it is essential navigation, it should not be part of sidebar links and should be moved above the filter.
This commit is contained in:
Krzysztof Kotlarek
2024-03-07 14:48:16 +11:00
committed by GitHub
parent a52ca0c932
commit 15ff33ae9e
6 changed files with 51 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spec/system/admin_sidebar_navigation_spec.rb
View File

@ -20,7 +20,7 @@ describe "Admin Revamp | Sidebar Navigation", type: :system do
expect(sidebar).to be_visible
expect(sidebar).to have_no_section("community")
expect(page).to have_no_css(".admin-main-nav")
sidebar.click_link_in_section("admin-nav-section-root", "back_to_forum")
filter.click_back_to_forum
expect(page).to have_current_path("/latest")
expect(sidebar).to have_no_section("admin-nav-section-root")
end
@ -44,7 +44,7 @@ describe "Admin Revamp | Sidebar Navigation", type: :system do
sidebar_dropdown.click
expect(sidebar).to have_no_section("community")
expect(page).to have_no_css(".admin-main-nav")
sidebar.click_link_in_section("admin-nav-section-root", "back_to_forum")
filter.click_back_to_forum
expect(page).to have_current_path("/latest")
sidebar_dropdown.click
expect(sidebar).to have_no_section("admin-nav-section-root")
@ -84,6 +84,7 @@ describe "Admin Revamp | Sidebar Navigation", type: :system do
links = page.all(".sidebar-section-link-content-text")
expect(links.count).to eq(all_links_count)
expect(page).to have_no_css(".sidebar-no-results")
expect(page).to have_css(".sidebar-sections__back-to-forum")
# When match section title, display all links
filter.filter("Backups")