github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-08 00:27:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Always return 0 for non-human user current DraftSequence.

Browse Source
This commit is contained in:
Guo Xiang Tan
2020-05-15 10:39:39 +08:00
parent 245e8212ca
commit 165fa13c9d
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/draft_sequence.rb
View File

@ -23,7 +23,7 @@ class DraftSequence < ActiveRecord::Base
user_id = user user_id = user
user_id = user.id unless user.is_a?(Integer) user_id = user.id unless user.is_a?(Integer)
return nil if invalid_user_id?(user_id) return 0 if invalid_user_id?(user_id)
# perf critical path # perf critical path
r, _ = DB.query_single('select sequence from draft_sequences where user_id = ? and draft_key = ?', user_id, key) r, _ = DB.query_single('select sequence from draft_sequences where user_id = ? and draft_key = ?', user_id, key)

2
spec/models/draft_sequence_spec.rb
View File

@ -24,7 +24,7 @@ describe DraftSequence do
it 'should return nil for non-human user' do it 'should return nil for non-human user' do
user.id = -99999 user.id = -99999
expect(DraftSequence.current(user, 'test')).to eq(nil) expect(DraftSequence.current(user, 'test')).to eq(0)
end end
it 'should return the right sequence' do it 'should return the right sequence' do