github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 07:11:34 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Change sidebar header dropdown to use wait_for_animation (#20627)

Browse Source 
* DEV: Change sidebar header dropdown to use wait_for_animation

Introduced in 54351e1b8a9b070bfce6a478e9912a76f1545a54, this
helper should remove the need to have to add the .animated
CSS class in JS for the sidebar.

* DEV: Revert spec change
This commit is contained in:
Martin Brennan
2023-03-10 14:54:57 +10:00
committed by GitHub
parent 5893ad46ba
commit 168de52538
6 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/system/page_objects/components/sidebar_header_dropdown.rb
View File

@ -5,9 +5,7 @@ module PageObjects
class SidebarHeaderDropdown < PageObjects::Components::Base
def click
page.find(".hamburger-dropdown").click
# `.animated` is important here because we want to wait until dropdown has finished its animation completely
page.has_css?(".menu-panel.animated")
wait_for_animation(find(".menu-panel"), timeout: 5)
self
end