github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-20 19:01:35 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: poll ranked choice result algo majority check (#28191)

Browse Source
This commit is contained in:
Robert
2024-08-02 07:51:26 +01:00
committed by GitHub
parent 26c4d1398a
commit 183ef2024c
2 changed files with 45 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/poll/lib/ranked_choice.rb
View File

@ -44,7 +44,7 @@ class DiscoursePoll::RankedChoice
potential_winners = find_potential_winners(tally, max_votes)
# Check for a majority and return if found
if majority_check(tally, potential_winners, max_votes)
if majority_check(tally, max_votes)
majority_candidate = enrich(potential_winners.keys.first, options)
round_activity << { round: round, majority: majority_candidate, eliminated: nil }
@ -112,10 +112,10 @@ class DiscoursePoll::RankedChoice
tally.select { |k, v| v == max_votes }
end
def self.majority_check(tally, potential_winners, max_votes)
def self.majority_check(tally, max_votes)
total_votes = tally.values.sum
max_votes > total_votes / 2 || potential_winners.count == 1
max_votes && max_votes > total_votes / 2
end
def self.identify_losers(tally)