github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-02 04:08:41 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: implements draft threads (#21361)

Browse Source 
This commit implements all the necessary logic to create thread seamlessly. For this it relies on the same logic used for messages and generates a `staged-id`(using the format: `staged-thread-CHANNEL_ID-MESSAGE_ID` which is used to re-conciliate state client sides once the thread has been persisted on the backend.

Part of this change the client side is now always using real thread and channel objects instead of sometimes relying on a flat `threadId` or `channelId`.

This PR also brings three UX changes:
- thread starts from top
- number of buttons on message actions is dependent of the width of the enclosing container
- <kbd>shift + ArrowUp</kbd> will reply to the last message
This commit is contained in:
Joffrey JAFFEUX
2023-05-05 08:55:55 +02:00
committed by GitHub
parent fe10c61dfa
commit 187b59d376
59 changed files with 1075 additions and 378 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
plugins/chat/spec/system/single_thread_spec.rb
View File

@ -123,8 +123,8 @@ describe "Single thread in side panel", type: :system, js: true do
chat_page.visit_channel(channel)
channel_page.message_thread_indicator(thread.original_message).click
expect(side_panel).to have_open_thread(thread)
thread_page.send_message(thread.id, "new thread message")
expect(thread_page).to have_message(thread.id, text: "new thread message")
thread_page.send_message("new thread message")
expect(thread_page).to have_message(thread_id: thread.id, text: "new thread message")
thread_message = thread.replies.last
expect(thread_message.chat_channel_id).to eq(channel.id)
expect(thread_message.thread.channel_id).to eq(channel.id)
@ -134,8 +134,8 @@ describe "Single thread in side panel", type: :system, js: true do
chat_page.visit_channel(channel)
channel_page.message_thread_indicator(thread.original_message).click
expect(side_panel).to have_open_thread(thread)
thread_page.send_message(thread.id, "new thread message")
expect(thread_page).to have_message(thread.id, text: "new thread message")
thread_page.send_message("new thread message")
expect(thread_page).to have_message(thread_id: thread.id, text: "new thread message")
thread_message = thread.reload.replies.last
expect(channel_page).not_to have_css(channel_page.message_by_id_selector(thread_message.id))
end
@ -157,19 +157,19 @@ describe "Single thread in side panel", type: :system, js: true do
using_session(:tab_2) do
expect(side_panel).to have_open_thread(thread)
thread_page.send_message(thread.id, "the other user message")
expect(thread_page).to have_message(thread.id, text: "the other user message")
thread_page.send_message("the other user message")
expect(thread_page).to have_message(thread_id: thread.id, text: "the other user message")
end
using_session(:tab_1) do
expect(side_panel).to have_open_thread(thread)
expect(thread_page).to have_message(thread.id, text: "the other user message")
thread_page.send_message(thread.id, "this is a test message")
expect(thread_page).to have_message(thread.id, text: "this is a test message")
expect(thread_page).to have_message(thread_id: thread.id, text: "the other user message")
thread_page.send_message("this is a test message")
expect(thread_page).to have_message(thread_id: thread.id, text: "this is a test message")
end
using_session(:tab_2) do
expect(thread_page).to have_message(thread.id, text: "this is a test message")
expect(thread_page).to have_message(thread_id: thread.id, text: "this is a test message")
end
end