github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 16:38:48 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Protect against accidental table renames

Browse Source
This commit is contained in:
Gerhard Schlager
2018-03-21 17:52:05 +01:00
committed by Sam
parent f2c060bdf2
commit 19c5afc69d
3 changed files with 31 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/migration/safe_migrate.rb
View File

@ -84,26 +84,26 @@ class Migration::SafeMigrate
end
def self.protect!(sql)
if sql =~ /^\s*drop\s+table/i
if sql =~ /^\s*(?:drop\s+table|alter\s+table.*rename\s+to)\s+/i
$stdout.puts("", <<~STR)
WARNING
-------------------------------------------------------------------------------------
An attempt was made to drop a table in a migration
An attempt was made to drop or rename a table in a migration
SQL used was: '#{sql}'
Please use the deferred pattrn using Migration::TableDropper in db/seeds to drop
the table.
Please use the deferred pattern using Migration::TableDropper in db/seeds to drop
or rename the table.
This protection is in place to protect us against dropping tables that are currently
in use by live applications.
STR
raise Discourse::InvalidMigration, "Attempt was made to drop a table"
elsif sql =~ /^\s*alter\s+table.*(rename|drop)/i
elsif sql =~ /^\s*alter\s+table.*(?:rename|drop)\s+/i
$stdout.puts("", <<~STR)
WARNING
-------------------------------------------------------------------------------------
An attempt was made to drop or rename a column in a migration
SQL used was: '#{sql}'
Please use the deferred pattrn using Migration::ColumnDropper in db/seeds to drop
Please use the deferred pattern using Migration::ColumnDropper in db/seeds to drop
or rename columns.
Note, to minimize disruption use self.ignored_columns = ["column name"] on your