github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 21:25:24 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FEATURE: Introduce site setting to allow for non staff pm tagging (#16671)

Browse Source 
Currently the only way to allow tagging on pms is to use the `allow_staff_to_tag_pms` site setting.  We are removing that site setting and replacing it with `pm_tags_allowed_for_groups` which will allow for non staff tagging. It will be group based permissions instead of requiring the user to be staff.

If the existing value of `allow_staff_to_tag_pms` is `true` then we include the `staff` groups as a default for `pm_tags_allowed_for_groups`.
This commit is contained in:
Isaac Janzen
2022-05-10 10:02:28 -05:00
committed by GitHub
parent cf273ec6e0
commit 1a12e4cfc8
17 changed files with 103 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spec/requests/categories_controller_spec.rb
View File

@ -333,7 +333,7 @@ describe CategoriesController do
describe "logged in" do
it "raises an exception if they don't have permission to see it" do
admin.update!(admin: false)
admin.update!(admin: false, group_users: [])
sign_in(admin)
get "/c/#{category.id}/show.json"
expect(response.status).to eq(403)