FIX: Correctly handle invalid auth cookies (#16995)

Previously it would blow up on invalid utf byte sequences. This was a source of spec flakiness.
This commit is contained in:
Jarek Radosz
2022-06-07 13:00:25 +02:00
committed by GitHub
parent 98671445a7
commit 1a5dbbf430
2 changed files with 7 additions and 4 deletions

View File

@ -29,6 +29,7 @@ describe Middleware::AnonymousCache do
it "is true if it has an invalid auth cookie" do
cookie = create_auth_cookie(token: SecureRandom.hex, issued_at: 5.minutes.ago)
cookie = swap_2_different_characters(cookie)
cookie.prepend("%a0%a1") # an invalid byte sequence
expect(new_helper("HTTP_COOKIE" => "jack=1; _t=#{cookie}; jill=2").cacheable?).to eq(true)
end
@ -376,5 +377,4 @@ describe Middleware::AnonymousCache do
expect(@status).to eq(403)
end
end
end